Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: duplicate aria labels #752

Merged
merged 3 commits into from
Nov 9, 2020
Merged

Fix: duplicate aria labels #752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb14d6d
Merge branch 'dev' into fix/accessibility-support
ElinorW Nov 2, 2020
a758cac
Update aria-label
ElinorW Nov 2, 2020
bffed00
localize aria labels
ElinorW Nov 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/app/views/query-runner/QueryInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { connect } from 'react-redux';
import { Mode } from '../../../types/enums';
import { IQueryInputProps } from '../../../types/query-runner';
import { getStyleFor } from '../../utils/badge-color';
import { translateMessage } from '../../utils/translate-messages';
import SubmitButton from '../common/submit-button/SubmitButton';
import { queryRunnerStyles } from './QueryRunner.styles';

Expand Down Expand Up @@ -72,7 +73,7 @@ export class QueryInput extends Component<IQueryInputProps, any> {
<div className='row'>
<div className='col-xs-12 col-lg-2'>
<Dropdown
ariaLabel='Query sample option'
ariaLabel={translateMessage('HTTP request method option')}
role='listbox'
selectedKey={selectedVerb}
options={httpMethodsToDisplay}
Expand All @@ -82,7 +83,7 @@ export class QueryInput extends Component<IQueryInputProps, any> {
</div>
<div className='col-xs-12 col-lg-2'>
<Dropdown
ariaLabel='Query sample option'
ariaLabel={translateMessage('Microsoft Graph API Version option')}
role='listbox'
selectedKey={selectedVersion || 'v1.0'}
options={urlVersions}
Expand All @@ -91,7 +92,7 @@ export class QueryInput extends Component<IQueryInputProps, any> {
</div>
<div className='col-xs-12 col-lg-6'>
<TextField
ariaLabel='Query Sample Input'
ariaLabel={translateMessage('Query Sample Input')}
role='textbox'
placeholder={messages['Query Sample']}
onChange={(event, value) => handleOnUrlChange(value)}
Expand Down
5 changes: 4 additions & 1 deletion src/messages/GE.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,5 +319,8 @@
"Administrator permission": "Admin of the tenant needs to authorize first before you can consent to this permission",
"Adaptive Cards designer": "Adaptive Cards designer.",
"Click Run Query button above to fetch Adaptive Card": "Click Run Query button above to fetch Adaptive Card.",
"Your history includes queries made in the last 30 days": "Your history includes queries made in the last 30 days"
"Your history includes queries made in the last 30 days": "Your history includes queries made in the last 30 days",
"HTTP request method option": "HTTP request method option",
"Microsoft Graph API Version option": "Microsoft Graph API Version option",
"Query Sample Input": "Query sample input"
}