-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: terminate process on entering multiple slash #824
Conversation
Cc. @thewahome |
@thewahome can you describe the bad from the original issue. I'm less concerned that it fired and failed as expected but it seems that if you backspace we don't get suggestions again. Fixing that would be good. Also note that this call in graph explorer does work |
@ddyett , I am going ahead to work on fixing that backspacing issue. |
Removed double slash fix and added a fix for autosuggestion on backspacing. Cc. @thewahome and @ddyett |
@ezkemboi the force push seems to have overwritten the previous slash changes... |
@thewahome, I have added it back. |
let filteredSuggestions = parametersWithVerb.links; | ||
if (compare) { | ||
filteredSuggestions = filteredSuggestions.filter((suggestion: string) => { | ||
return suggestion.toLowerCase().indexOf(compare.toLowerCase()) > -1; | ||
}); | ||
} | ||
|
||
this.setSuggestions(filteredSuggestions); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ezkemboi why was this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found that the branch was just behind the main repo's dev.
* Fix: url truncation (#1012) * Fix: improve themes MessageBar colors (#1015) * Fix: Response Preview truncation (#1017) * Feature: Have permissions be filtered (DelegatedWork or DelegatedPersonal) based on account type (#1008) * Fix: terminate process on entering multiple slash (#824) * Task: change sandbox url (#992)
Overview
Brief description of what this PR does, and why it is needed.
Demo
Optional. Screenshots,
curl
examples, etc.Notes
Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.
Testing Instructions