Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: repopulate modify permissions when panel closed #999

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

thewahome
Copy link
Collaborator

@thewahome thewahome commented Jun 16, 2021

Overview

Closes #994

Scenario:

  • A user opens a query's modify permission page
  • The user opens the permissions panel
  • The user closes the permissions panel and is now back on the modify permissions page

The fix now repopulates the modify permissions screen with the permissions (if any) of the query URL that is in the URL bar

Demo

Follow this link: https://jolly-sand-0ac78c710-999.centralus.azurestaticapps.net/

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • Log in to GE
  • Select my mail and take note of the permissions displayed
  • Head over to the more actions icon and open the Select Permissions panel
  • Close the Select Permissions panel
  • Notice the original permissions belonging to my mail are displayed again

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-999.centralus.azurestaticapps.net

@thewahome thewahome merged commit f3732f8 into dev Jun 17, 2021
thewahome added a commit that referenced this pull request Jul 6, 2021
* Fix: Accessibility bugs - June (#991) 

* Fix: Clear the user's profile on sign out (#1000)

* Fix: repopulate modify permissions when panel closed (#999)

* Fix: Accessibility bugs (Jul-Sep) (#1010)

* Task: Collect telemetry data for fetching adaptive card templates (#1004)

* Task: Capture telemetry for response headers copy action (#1003)

* Task: Add telemetry for Report an Issue Link (#1011)

* Fix: url truncation (#1012)
acchiang pushed a commit to LokiLabs/microsoft-graph-explorer-v4 that referenced this pull request Jul 6, 2021
)

* repopulate open modify permissions when permissions panel is closed

* move all fetch scopes logic to action creator
@thewahome thewahome deleted the fix/repopulate-modify-permissions-when-panel-closed branch August 6, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify permissions tab deletes all permissions when you move to the select permissions option
2 participants