Skip to content

Commit

Permalink
fix: stop keydown from bubbling beyond people-picker (#2892)
Browse files Browse the repository at this point in the history
this ensures that keystrokes which might trigger in pages shortcuts in SharePoint don't reach those event listener and break the component experience
  • Loading branch information
gavinbarron committed Nov 30, 2023
1 parent f3e8599 commit ad4cfa3
Showing 1 changed file with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1548,6 +1548,7 @@ export class MgtPeoplePicker extends MgtTemplatedComponent {
* @param event - event tracked on user input (keydown)
*/
private readonly onUserKeyDown = (event: KeyboardEvent): void => {
event.stopPropagation();
const keyName = event.key;
const selectedList = this.renderRoot.querySelector('.selected-list');
const isCmdOrCtrlKey = event.getModifierState('Control') || event.getModifierState('Meta');
Expand Down Expand Up @@ -1595,7 +1596,6 @@ export class MgtPeoplePicker extends MgtTemplatedComponent {
if (keyName === 'Enter') {
if (!event.shiftKey && this._foundPeople) {
event.preventDefault();
event.stopPropagation();

const foundPerson = this._foundPeople[this._arrowSelectionCount];
if (foundPerson) {
Expand All @@ -1613,10 +1613,6 @@ export class MgtPeoplePicker extends MgtTemplatedComponent {
}
}

if (keyName === 'Escape') {
event.stopPropagation();
}

if (keyName === 'Tab') {
this.hideFlyout();
}
Expand Down

0 comments on commit ad4cfa3

Please sign in to comment.