Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mgt-todo] Allow editing of todos #2161

Closed
gavinbarron opened this issue Mar 30, 2023 · 7 comments · Fixed by #2783
Closed

[mgt-todo] Allow editing of todos #2161

gavinbarron opened this issue Mar 30, 2023 · 7 comments · Fixed by #2783

Comments

@gavinbarron
Copy link
Member

Proposal: Add edit mode to mgt-todo

Description

Currently users of the mgt-todo component can only complete or uncomplete a todo item. A user should be able to edit all fields on the todo

Rationale

We want users to love this component, not having an edit mode feels like a miss

Preferred Solution

Design required to show an edit mode and a ui action to enter edit mode

@ghost
Copy link

ghost commented Mar 30, 2023

Hello gavinbarron, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@gavinbarron
Copy link
Member Author

@yejuntak if you could please work on some designs for how to edit todo items inline

@yejuntak
Copy link
Contributor

yejuntak commented Jul 20, 2023

Screenshot 2023-07-20 at 12 44 44 PM

The design has been updated to the figma link. If you have any issue or questions please ping me on Teams.

https://www.figma.com/file/2uBa2lODCTSj1CZSI6USee/Microsoft-Graph-Toolkit?type=design&node-id=8068%3A141398&mode=design&t=Ayin4dc8b8Msqpxk-1

@gavinbarron
Copy link
Member Author

Awesome, thanks @yejuntak, I've added some comments to the Figma file

@sebastienlevert
Copy link
Contributor

Same here. I think we're onto something!

@sebastienlevert sebastienlevert removed this from the v3.1.0 milestone Aug 14, 2023
@yejuntak
Copy link
Contributor

yejuntak commented Sep 7, 2023

This has been updated and edited to our MGT figma file. Same link as above. Please take a look.

@sebastienlevert
Copy link
Contributor

Reopening and adding in our Ready bucket to start implementation!

@Mnickii Mnickii self-assigned this Oct 4, 2023
@sebastienlevert sebastienlevert changed the title [mgt-todo] Allow editing of todos [mgt-todo] Allow editing of todos Oct 10, 2023
@sebastienlevert sebastienlevert added this to the v4.0.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants