-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update Todo component to new Fluent designs #1967
Conversation
Thank you for creating a Pull Request @Mnickii. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
767a516
to
04f050c
Compare
The updated storybook is available here |
1 similar comment
The updated storybook is available here |
The updated storybook is available here |
The updated storybook is available here |
@Mnickii I see there are 3 items left that are design related.
Once these are completed, I think we will be good to close this issue! 🎉 |
The updated storybook is available here |
@sebastienlevert the checkmark issues have been fixed by shifting to use fluent-checkbox rather than fluent-radio that doesn't allow selection of multiple items. |
The updated storybook is available here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mnickii all seems great except the hover effects on the hovered task. I don't see any changes. Besides that, we're good to go!
The updated storybook is available here |
@sebastienlevert This whole time, I missed a small typo 😭 |
The updated storybook is available here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHIP IT! 🎉🎉🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀Ship It!
Closes #1710
Closes #2082
Closes #2084
PR Type
Feature
Description of the changes
Updates Todo component to new fluent design
Includes new mgt-picker and it's theme updates
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information
Requires #2048 to adequately test Task lists and Todo tasks on storybook.