Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Todo component to new Fluent designs #1967

Merged
merged 101 commits into from
Apr 28, 2023

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Nov 29, 2022

Closes #1710
Closes #2082
Closes #2084

PR Type

Feature

Description of the changes

Updates Todo component to new fluent design
Includes new mgt-picker and it's theme updates

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Requires #2048 to adequately test Task lists and Todo tasks on storybook.

@ghost
Copy link

ghost commented Nov 29, 2022

Thank you for creating a Pull Request @Mnickii.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

The updated storybook is available here

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

@sebastienlevert
Copy link
Contributor

sebastienlevert commented Apr 24, 2023

@Mnickii I see there are 3 items left that are design related.

  • There are no indication on which task we have hovering
    Screenshot-20230424-153736
  • When completing a task, we are losing borders and it make things move a little bit
    Screenshot-20230424-153639
  • When completing multiple tasks on one go, only the last task gets the checkmark
    image

Once these are completed, I think we will be good to close this issue! 🎉

@github-actions
Copy link

The updated storybook is available here

@Mnickii
Copy link
Collaborator Author

Mnickii commented Apr 27, 2023

@sebastienlevert the checkmark issues have been fixed by shifting to use fluent-checkbox rather than fluent-radio that doesn't allow selection of multiple items.

@github-actions
Copy link

The updated storybook is available here

Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mnickii all seems great except the hover effects on the hovered task. I don't see any changes. Besides that, we're good to go!

@ghost ghost added the Needs: Author Feedback Issue needs response from issue author label Apr 27, 2023
@github-actions
Copy link

The updated storybook is available here

@Mnickii
Copy link
Collaborator Author

Mnickii commented Apr 28, 2023

@sebastienlevert This whole time, I missed a small typo 😭

@ghost ghost removed the Needs: Author Feedback Issue needs response from issue author label Apr 28, 2023
@github-actions
Copy link

The updated storybook is available here

@sebastienlevert sebastienlevert self-requested a review April 28, 2023 17:19
Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIP IT! 🎉🎉🎉

Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀Ship It!

@gavinbarron gavinbarron merged commit c7bf047 into next/fluentui Apr 28, 2023
4 checks passed
@gavinbarron gavinbarron deleted the mnickii/todo-fluent-update branch April 28, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
5 participants