Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] mgt-person no cursor change on hover #2651

Closed
agaskelluk opened this issue Aug 9, 2023 · 6 comments · Fixed by #2652
Closed

[BUG] mgt-person no cursor change on hover #2651

agaskelluk opened this issue Aug 9, 2023 · 6 comments · Fixed by #2652
Assignees
Labels
bug Something isn't working State: In Review

Comments

@agaskelluk
Copy link
Contributor

When the mgt-person component has been configured to display the person-card on hover or click, the cursor icon should change to a "hand", like the OOTB People web parts that Microsoft provides to SharePoint.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://mgt.dev/?path=/story/components-mgt-person-properties--person-card&source=docs'
  2. Hover on the first mgt-person component or click the 2nd component.

Expected behavior
The mouse pointer should change to a hand to in both components.

Screenshots
The default cursor isn't visible here, but hopefully you get the idea anyway.
Capture

Environment (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Framework Playground, but reproduced in custom spfx in SP.
  • Context Web and SharePoint
  • Version 3.1.0
  • Provider Playground and SharePointProvider.

Additional context
It's not obvious to the user that there is functionality to show more details about a person i.e. the person-card, when hovering or clicking because the mouse cursor state does not change when hovering. I really don't want the user to miss out on this great functionality because of this!

@agaskelluk agaskelluk added bug Something isn't working Needs: Triage 🔍 labels Aug 9, 2023
@agaskelluk
Copy link
Contributor Author

Note that a custom css property is easy to apply and works well. I added a simple: cursor: pointer; and it works well but I feel this should be available OOTB.

@sebastienlevert
Copy link
Contributor

Thanks for the issue @agaskelluk! I agree and I'm adding our designer @yejuntak to reply with his thoughts. Would you be willing to submit a PR to fix this issue? Thanks!

@agaskelluk
Copy link
Contributor Author

@sebastienlevert Yes I can do that. I will let you know when its ready.

@sebastienlevert
Copy link
Contributor

We appreciate it @agaskelluk. Let us know how we can help!

@agaskelluk
Copy link
Contributor Author

@sebastienlevert I have just opened a pull request for this. Please let me know how it goes.

@yejuntak
Copy link
Contributor

Hello @agaskelluk after we did design review. We want to have the corresponding interaction throughout all Microsoft products and no product have indication change with hover option. However, with clickable option, I agree that we should have the hand pointer for the cursor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working State: In Review
Projects
Archived in project
3 participants