feat!: split config and permission methods out of mgt-person-card #2840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-card splits out the logic for cacluating the scopes required for the mgt-person-card into a separate function and file splits the static config for MgtPersonCard into a separate class changes the schema of the config for MgtPersonCard fixes an issue where setting isSendMessageVisible to false did not stop the quick message ui from rendering adds tests to validate the permission sets BREAKING CHANGE: MgtPersonCard no longer has a static config property.This config has been moved to the MgtPersonCardConfig class to allow developers to import the config and associated getMgtPersonCardScopes function at the top level of their applicaiton without automatically adding the weight of the full mgt-person-card component and dependencies to the entry file for their applications. BREAKING CHANGE: The organization section for configuring MgtPersonCard may no longer be set to false, use undefined instead.
|
🚀 New react-contoso sample application deployed here |
|
📖 The updated storybook is available here |
|
📖 The updated storybook is available here |
|
|
🚀 New react-contoso sample application deployed here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2839
PR Type
Description of the changes
splits out the logic for cacluating the scopes required for the mgt-person-card into a separate function and file splits the static config for MgtPersonCard into a separate class changes the schema of the config for MgtPersonCard fixes an issue where setting isSendMessageVisible to false did not stop the quick message ui from rendering adds tests to validate the permission sets
BREAKING CHANGE: MgtPersonCard no longer has a static config property.This config has been moved to the MgtPersonCardConfig class to allow developers to import the config and associated getMgtPersonCardScopes function at the top level of their applicaiton without automatically adding the weight of the full mgt-person-card component and dependencies to the entry file for their applications.
BREAKING CHANGE: The organization section for configuring MgtPersonCard may no longer be set to false, use undefined instead.
PR checklist
yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense)Other information
BEGIN_COMMIT_OVERRIDE
feat!: split config and permission methods out of mgt-person-card (#2840)
splits out the logic for cacluating the scopes required for the mgt-person-card into a separate function and file
splits the static config for MgtPersonCard into a separate class
fixes an issue where setting isSendMessageVisible to false did not stop the quick message ui from rendering
adds tests to validate the permission sets
BREAKING CHANGE: MgtPersonCard no longer has a static config property.This config has been moved to the MgtPersonCardConfig class to allow developers to import the config and associated getMgtPersonCardScopes function at the top level of their applicaiton without automatically adding the weight of the full mgt-person-card component and dependencies to the entry file for their applications.
feat!: change schema of organization section in MgtPersonCardConfig (#2840)
BREAKING CHANGE: The organization section for configuring MgtPersonCard may no longer be set to false, use undefined instead.
BEGIN_COMMIT_END