Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: split config and permission methods out of mgt-person-card #2840

Merged
merged 3 commits into from
Nov 10, 2023
Merged

feat!: split config and permission methods out of mgt-person-card #2840

merged 3 commits into from
Nov 10, 2023

Commits on Nov 10, 2023

  1. feat!: split static config and permission methods out of mgt-personon… 

    …-card

splits out the logic for cacluating the scopes required for the mgt-person-card into a separate function and file
splits the static config for MgtPersonCard into a separate class
changes the schema of the config for MgtPersonCard
fixes an issue where setting isSendMessageVisible to false did not stop the quick message ui from rendering
adds tests to validate the permission sets

BREAKING CHANGE: MgtPersonCard no longer has a static config property.This config has been moved to the MgtPersonCardConfig class to allow developers to import the config and associated getMgtPersonCardScopes function at the top level of their applicaiton without automatically adding the weight of the full mgt-person-card component and dependencies to the entry file for their applications.
BREAKING CHANGE: The organization section for configuring MgtPersonCard may no longer be set to false, use undefined instead.
    @gavinbarron
    gavinbarron committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    582d5ec View commit details
    Browse the repository at this point in the history

  2. clean up dead import

    @gavinbarron
    gavinbarron committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    7802228 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/person-card-config-and-permissions

    @gavinbarron
    gavinbarron committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    26525f8 View commit details
    Browse the repository at this point in the history