Addressed PR comments #1048
Merged
Addressed PR comments #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for creating a Pull Request @amrutha95. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
nmetulev
approved these changes
Apr 28, 2021
nmetulev
added a commit
that referenced
this pull request
Apr 28, 2021
* Added electron app * delete * Added electron sample folder * Added electron sample folder * Added electron sample folder * added electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Update README.md * Added license * Cleaned up license * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update samples/electron-app/package.json Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Review comments & removed cache plugin * Update packages/providers/mgt-electron-provider/src/Authenticator/CustomFileProtocol.ts Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Changed initialization of ElectronAuthenticator * updated sample readme * Update README.md * Removed all evidence of incremental consent support :P * Warning * MSAL2.0 * msal2 silent * Added msal2 custom element and sso * SSO fix * Added event on account switch * Fixed issue with setActiveAccount related to latest msal-browser package * Bumped up package version * temp fix * Single account * Added new test file * Update msal2-provider-test.html * Single account changes * Comments * Added msal2.0 provider to index.html * Added msal2.0 provider to index.html * enabled multi account * handle account changes in providers namespace * Comments * Revert "enabled multi account" This reverts commit 7f94528. * fixed binding issue * cleanup * fixed when unsubscribing * Added docs and removed account object * fixed bugs and enabled multi login * swapped provider and disabled cache * updated login ui using fluent listbox * ui and svg * arrow selection * fix hover for first selected item * profile size, spacing * fix package.json * hover state css * adds max-width, overflow for names * fixing spacing * Changes to mgt-login to store person image (#1046) Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * Changes to mgt-login part 2 (#1047) * Changes to mgt-login to store person image * PR comments Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * additional handling for overflow * tab indexing too * Update packages/mgt-components/src/components/mgt-login/mgt-login.ts Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Addressed PR comments (#1048) * Changes to mgt-login to store person image * PR comments * PR comments Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * Update packages/mgt-components/src/components/mgt-login/mgt-login.ts * handling for single user login and one user signed in multiuser * updating avatar-direction to person-flex-direction Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Shane Weaver <shweaver@microsoft.com> Co-authored-by: amrutha95 <amrutha.srinivasan95@gmail.com> Co-authored-by: Nikola Metulev <nikolame@microsoft.com>
Mnickii
pushed a commit
that referenced
this pull request
Jun 28, 2022
* Added electron app * delete * Added electron sample folder * Added electron sample folder * Added electron sample folder * added electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Update README.md * Added license * Cleaned up license * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update samples/electron-app/package.json Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Review comments & removed cache plugin * Update packages/providers/mgt-electron-provider/src/Authenticator/CustomFileProtocol.ts Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Changed initialization of ElectronAuthenticator * updated sample readme * Update README.md * Removed all evidence of incremental consent support :P * Warning * MSAL2.0 * msal2 silent * Added msal2 custom element and sso * SSO fix * Added event on account switch * Fixed issue with setActiveAccount related to latest msal-browser package * Bumped up package version * temp fix * Single account * Added new test file * Update msal2-provider-test.html * Single account changes * Comments * Added msal2.0 provider to index.html * Added msal2.0 provider to index.html * enabled multi account * handle account changes in providers namespace * Comments * Revert "enabled multi account" This reverts commit 7f94528. * fixed binding issue * cleanup * fixed when unsubscribing * Added docs and removed account object * fixed bugs and enabled multi login * swapped provider and disabled cache * updated login ui using fluent listbox * ui and svg * arrow selection * fix hover for first selected item * profile size, spacing * fix package.json * hover state css * adds max-width, overflow for names * fixing spacing * Changes to mgt-login to store person image (#1046) Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * Changes to mgt-login part 2 (#1047) * Changes to mgt-login to store person image * PR comments Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * additional handling for overflow * tab indexing too * Update packages/mgt-components/src/components/mgt-login/mgt-login.ts Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Addressed PR comments (#1048) * Changes to mgt-login to store person image * PR comments * PR comments Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * Update packages/mgt-components/src/components/mgt-login/mgt-login.ts * handling for single user login and one user signed in multiuser * updating avatar-direction to person-flex-direction Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Shane Weaver <shweaver@microsoft.com> Co-authored-by: amrutha95 <amrutha.srinivasan95@gmail.com> Co-authored-by: Nikola Metulev <nikolame@microsoft.com>
Mnickii
pushed a commit
that referenced
this pull request
Aug 11, 2022
* Added electron app * delete * Added electron sample folder * Added electron sample folder * Added electron sample folder * added electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Update README.md * Added license * Cleaned up license * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update samples/electron-app/package.json Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Review comments & removed cache plugin * Update packages/providers/mgt-electron-provider/src/Authenticator/CustomFileProtocol.ts Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Changed initialization of ElectronAuthenticator * updated sample readme * Update README.md * Removed all evidence of incremental consent support :P * Warning * MSAL2.0 * msal2 silent * Added msal2 custom element and sso * SSO fix * Added event on account switch * Fixed issue with setActiveAccount related to latest msal-browser package * Bumped up package version * temp fix * Single account * Added new test file * Update msal2-provider-test.html * Single account changes * Comments * Added msal2.0 provider to index.html * Added msal2.0 provider to index.html * enabled multi account * handle account changes in providers namespace * Comments * Revert "enabled multi account" This reverts commit 7f94528. * fixed binding issue * cleanup * fixed when unsubscribing * Added docs and removed account object * fixed bugs and enabled multi login * swapped provider and disabled cache * updated login ui using fluent listbox * ui and svg * arrow selection * fix hover for first selected item * profile size, spacing * fix package.json * hover state css * adds max-width, overflow for names * fixing spacing * Changes to mgt-login to store person image (#1046) Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * Changes to mgt-login part 2 (#1047) * Changes to mgt-login to store person image * PR comments Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * additional handling for overflow * tab indexing too * Update packages/mgt-components/src/components/mgt-login/mgt-login.ts Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Addressed PR comments (#1048) * Changes to mgt-login to store person image * PR comments * PR comments Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * Update packages/mgt-components/src/components/mgt-login/mgt-login.ts * handling for single user login and one user signed in multiuser * updating avatar-direction to person-flex-direction Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Shane Weaver <shweaver@microsoft.com> Co-authored-by: amrutha95 <amrutha.srinivasan95@gmail.com> Co-authored-by: Nikola Metulev <nikolame@microsoft.com>
musale
added a commit
that referenced
this pull request
Aug 22, 2022
* Set the aria-label text for the buttons (#1708) * Set the aria-label for the button This allows the login component to have an encapsulating button which has an aria-label that is set depending on whether a user is signed in (sets the displayName) or signed out (sets the 'Sign In' string). * Check for a provider for storybook use case * Check the provider exists before checking the state on it * Set the aria-label for custom strings * Added aria-label text for buttons in person-card * [mgt-teamsfx-provider] update peer dependency to support teamsfx sdk 1.x.x (#1722) Co-authored-by: turenlong <rentu@microsoft.com> * Adding the spec for mgt-picker v2. (#1714) Co-authored-by: Musale Martin <martinmusale@microsoft.com> * Allow tab navigation to be lockable within the person-card (#1726) * Add tab navigation locking to the person card * Allow tabbing navigation to be lockable in person-card * Add generated react file * Adding TeamsFx to the Overview page (#1738) * [accessibility] fix keyboard controls in localization (#1720) Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> * [mgt-person-card] Accessibility, zoom or window height minimums for content (#1731) Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> * Updates mgt-spfx to SPFx@1.15.0 (#1742) * Bump Newtonsoft.Json in /samples/proxy-provider-asp-net-core (#1732) Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.3 to 13.0.1. - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@12.0.3...13.0.1) --- updated-dependencies: - dependency-name: Newtonsoft.Json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update role to searchbox (#1757) Co-authored-by: Musale Martin <martinmusale@microsoft.com> * Update aria-roles and add aria-labels (#1761) * update aria-roles and add aria-labels * add aria-label * chore: Add `.github/fabricbot.json` (#1734) Co-authored-by: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Co-authored-by: Gavin Barron <gavin.barron@gmail.com> * chore(deps): update sample angular app dependencies (#1762) * Rebuilt package-lock.json to address security advisories * bumping @anglar/cli to v10 * bumping to Angular 10 * Bumping to Angular 11 and updating tailwind config * downgrade tailwind for ng update * updated package-lock for tailwind downgrade * Bumping to Angular 12 * Bumping @angular-builders/custom-webpack to match angular version Co-authored-by: Musale Martin <martinmusale@microsoft.com> * Update TeamsFx Provider README.md (#1755) Co-authored-by: Musale Martin <martinmusale@microsoft.com> * docs: fix proxy provider sample readme (#1759) Clarifies the supported account types that can be used Updates flow of instructions to align to portal updates Fixes port used launchSettings when running from command line Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> * Fix freezing tabs on Safari (#1770) Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> * Add group-ids attribute to the people-picker component (#1652) Co-authored-by: Nickii Miaro <miaronkirote@gmail.com> Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> * fix: change sppkg details for mgt-spfx Updates the sppkg file name to use the pattern mgt-spfx-v{majorVersion}.sppkg Updates the solution name to "Microsoft Graph Toolkit v2 for SPFx" Co-authored-by: Gavin Barron <gavinbarron@microsoft.com> * fix: prevent unsafe access to dom nodes in getDocumentDirection (#1788) If a provider is in the head using mgt-loader the synchronous loading of mgt scripts causes LocaliztionHelper to attempt to access the body DOM node of the document before the browser has parsed the entire document causing body to be null. Using optional chaining avoids trying to call a method on a null object. * Bump Newtonsoft.Json from 11.0.1 to 13.0.1 in /samples/proxy-provider-asp-net-mvc/graph-tutorial (#1733) * Bump Newtonsoft.Json Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 11.0.1 to 13.0.1. - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@11.0.1...13.0.1) --- updated-dependencies: - dependency-name: Newtonsoft.Json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Updated assembly binding redirect to fix broken sample application Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gavin Barron <gavinbarron@microsoft.com> * fix: email resolution on paste for people picker (#1791) Closes #1763 Adds special handling for keyUp when pasting to resolve email addresses * Revert move of getUsers, fixes #1795 (#1798) Co-authored-by: Anders Roos <Anders.roos@nethouse.se> * Clear defaultPeople on forced state update, fixes #1796 (#1799) Co-authored-by: Anders Roos <Anders.roos@nethouse.se> * msal2 multi-account UI (#1041) * Added electron app * delete * Added electron sample folder * Added electron sample folder * Added electron sample folder * added electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Update README.md * Added license * Cleaned up license * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update samples/electron-app/package.json Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Review comments & removed cache plugin * Update packages/providers/mgt-electron-provider/src/Authenticator/CustomFileProtocol.ts Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Changed initialization of ElectronAuthenticator * updated sample readme * Update README.md * Removed all evidence of incremental consent support :P * Warning * MSAL2.0 * msal2 silent * Added msal2 custom element and sso * SSO fix * Added event on account switch * Fixed issue with setActiveAccount related to latest msal-browser package * Bumped up package version * temp fix * Single account * Added new test file * Update msal2-provider-test.html * Single account changes * Comments * Added msal2.0 provider to index.html * Added msal2.0 provider to index.html * enabled multi account * handle account changes in providers namespace * Comments * Revert "enabled multi account" This reverts commit 7f94528. * fixed binding issue * cleanup * fixed when unsubscribing * Added docs and removed account object * fixed bugs and enabled multi login * swapped provider and disabled cache * updated login ui using fluent listbox * ui and svg * arrow selection * fix hover for first selected item * profile size, spacing * fix package.json * hover state css * adds max-width, overflow for names * fixing spacing * Changes to mgt-login to store person image (#1046) Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * Changes to mgt-login part 2 (#1047) * Changes to mgt-login to store person image * PR comments Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * additional handling for overflow * tab indexing too * Update packages/mgt-components/src/components/mgt-login/mgt-login.ts Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Addressed PR comments (#1048) * Changes to mgt-login to store person image * PR comments * PR comments Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * Update packages/mgt-components/src/components/mgt-login/mgt-login.ts * handling for single user login and one user signed in multiuser * updating avatar-direction to person-flex-direction Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Shane Weaver <shweaver@microsoft.com> Co-authored-by: amrutha95 <amrutha.srinivasan95@gmail.com> Co-authored-by: Nikola Metulev <nikolame@microsoft.com> * Added multi-user cache functionality and enabled multi user login in Msal2Provider (#1299) Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Nicolas Vogt <NicolasVogt@TGSADMINs-MacBook-Pro.local> * [Fluent-UI][person-card] fluent controls upgrade (#1253) Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: Nicolas Vogt <NicolasVogt@TGSADMINs-MacBook-Pro.local> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Updated Graph Client to v3 (#1040) * updated Graph Client to v3.0.0 for all packages * Update README.md * updated login ui using fluent listbox * Update fluentui registration code * chore: Update aria-labels for base-icons * fix: font on email and chat labels * chore: bump fluentui to latest Co-authored-by: Nikola Metulev <nikolame@microsoft.com> Co-authored-by: Nicolas Vogt <nicolasjvogt@gmail.com> Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Shane Weaver <shweaver@microsoft.com> Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: André Lage <ponto_portuca@hotmail.com> Co-authored-by: Musale Martin <martinmusale@microsoft.com> Co-authored-by: Kyle <kylelobsinger@gmail.com> Co-authored-by: Gavin Barron <gavinbarron@microsoft.com> * [person]: Update person component to latest Fluent UI design (#1773) * update horizontal design * update person pill * fix user presence * update unauthenticated user design, fix avatar styles and accessibility * add vertical layout, fix presence, update pill * fix unauthenticated with email design * fix line2property on vertical layout * update person events and templating stories * fix view spacings, update rtl * fix vertical display * fix avatar-text spacings * remove comments, add file story * fix colour contrast * update vertical stylings * fix black person on person-card, update line2 property on login * Set the aria-label text for the buttons (#1708) * Set the aria-label for the button This allows the login component to have an encapsulating button which has an aria-label that is set depending on whether a user is signed in (sets the displayName) or signed out (sets the 'Sign In' string). * Check for a provider for storybook use case * Check the provider exists before checking the state on it * Set the aria-label for custom strings * Added aria-label text for buttons in person-card * [Person] fixed issue 1579 (#1682) * fixed issue #1579 * Adding object-fit and position to avoid stretch Co-authored-by: Musale Martin <martinmusale@microsoft.com> Co-authored-by: Nickii Miaro <miaronkirote@gmail.com> Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> Co-authored-by: Sébastien Levert <slevert@outlook.com> * fix build * update: fix rebase and style issues * update: use variables for style colors * update: adds in story for rendered icon when initials not available * update: use variable for wrapper hover * update: fix user presence Co-authored-by: Musale Martin <martinmusale@microsoft.com> Co-authored-by: wuxiaojun514 <wuxiaojun514@163.com> Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> Co-authored-by: Sébastien Levert <slevert@outlook.com> * fix build after rebase Co-authored-by: Musale Martin <martinmusale@microsoft.com> Co-authored-by: rentu <5545529+SLdragon@users.noreply.github.com> Co-authored-by: turenlong <rentu@microsoft.com> Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> Co-authored-by: Nicolas Vogt <nicolasjvogt@gmail.com> Co-authored-by: Waldek Mastykarz <waldek@mastykarz.nl> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Elinor <elkaguon@microsoft.com> Co-authored-by: Elinor <ekaguongo@gmail.com> Co-authored-by: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Co-authored-by: Gavin Barron <gavin.barron@gmail.com> Co-authored-by: Gavin Barron <gavinbarron@microsoft.com> Co-authored-by: Hilton Giesenow <hilton@giesenow.com> Co-authored-by: Anders Roos <malakeen@gmail.com> Co-authored-by: Anders Roos <Anders.roos@nethouse.se> Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Shane Weaver <shweaver@microsoft.com> Co-authored-by: amrutha95 <amrutha.srinivasan95@gmail.com> Co-authored-by: Nikola Metulev <nikolame@microsoft.com> Co-authored-by: Nicolas Vogt <NicolasVogt@TGSADMINs-MacBook-Pro.local> Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: André Lage <ponto_portuca@hotmail.com> Co-authored-by: Kyle <kylelobsinger@gmail.com> Co-authored-by: wuxiaojun514 <wuxiaojun514@163.com> Co-authored-by: Sébastien Levert <slevert@outlook.com>
Mnickii
pushed a commit
that referenced
this pull request
Sep 7, 2022
* Added electron app * delete * Added electron sample folder * Added electron sample folder * Added electron sample folder * added electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Update README.md * Added license * Cleaned up license * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update samples/electron-app/package.json Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Review comments & removed cache plugin * Update packages/providers/mgt-electron-provider/src/Authenticator/CustomFileProtocol.ts Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Changed initialization of ElectronAuthenticator * updated sample readme * Update README.md * Removed all evidence of incremental consent support :P * Warning * MSAL2.0 * msal2 silent * Added msal2 custom element and sso * SSO fix * Added event on account switch * Fixed issue with setActiveAccount related to latest msal-browser package * Bumped up package version * temp fix * Single account * Added new test file * Update msal2-provider-test.html * Single account changes * Comments * Added msal2.0 provider to index.html * Added msal2.0 provider to index.html * enabled multi account * handle account changes in providers namespace * Comments * Revert "enabled multi account" This reverts commit 7f94528. * fixed binding issue * cleanup * fixed when unsubscribing * Added docs and removed account object * fixed bugs and enabled multi login * swapped provider and disabled cache * updated login ui using fluent listbox * ui and svg * arrow selection * fix hover for first selected item * profile size, spacing * fix package.json * hover state css * adds max-width, overflow for names * fixing spacing * Changes to mgt-login to store person image (#1046) Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * Changes to mgt-login part 2 (#1047) * Changes to mgt-login to store person image * PR comments Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * additional handling for overflow * tab indexing too * Update packages/mgt-components/src/components/mgt-login/mgt-login.ts Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Addressed PR comments (#1048) * Changes to mgt-login to store person image * PR comments * PR comments Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * Update packages/mgt-components/src/components/mgt-login/mgt-login.ts * handling for single user login and one user signed in multiuser * updating avatar-direction to person-flex-direction Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Shane Weaver <shweaver@microsoft.com> Co-authored-by: amrutha95 <amrutha.srinivasan95@gmail.com> Co-authored-by: Nikola Metulev <nikolame@microsoft.com>
Mnickii
added a commit
that referenced
this pull request
Sep 7, 2022
* Set the aria-label text for the buttons (#1708) * Set the aria-label for the button This allows the login component to have an encapsulating button which has an aria-label that is set depending on whether a user is signed in (sets the displayName) or signed out (sets the 'Sign In' string). * Check for a provider for storybook use case * Check the provider exists before checking the state on it * Set the aria-label for custom strings * Added aria-label text for buttons in person-card * [mgt-teamsfx-provider] update peer dependency to support teamsfx sdk 1.x.x (#1722) Co-authored-by: turenlong <rentu@microsoft.com> * Adding the spec for mgt-picker v2. (#1714) Co-authored-by: Musale Martin <martinmusale@microsoft.com> * Allow tab navigation to be lockable within the person-card (#1726) * Add tab navigation locking to the person card * Allow tabbing navigation to be lockable in person-card * Add generated react file * Adding TeamsFx to the Overview page (#1738) * [accessibility] fix keyboard controls in localization (#1720) Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> * [mgt-person-card] Accessibility, zoom or window height minimums for content (#1731) Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> * Updates mgt-spfx to SPFx@1.15.0 (#1742) * Bump Newtonsoft.Json in /samples/proxy-provider-asp-net-core (#1732) Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.3 to 13.0.1. - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@12.0.3...13.0.1) --- updated-dependencies: - dependency-name: Newtonsoft.Json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update role to searchbox (#1757) Co-authored-by: Musale Martin <martinmusale@microsoft.com> * Update aria-roles and add aria-labels (#1761) * update aria-roles and add aria-labels * add aria-label * chore: Add `.github/fabricbot.json` (#1734) Co-authored-by: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Co-authored-by: Gavin Barron <gavin.barron@gmail.com> * chore(deps): update sample angular app dependencies (#1762) * Rebuilt package-lock.json to address security advisories * bumping @anglar/cli to v10 * bumping to Angular 10 * Bumping to Angular 11 and updating tailwind config * downgrade tailwind for ng update * updated package-lock for tailwind downgrade * Bumping to Angular 12 * Bumping @angular-builders/custom-webpack to match angular version Co-authored-by: Musale Martin <martinmusale@microsoft.com> * Update TeamsFx Provider README.md (#1755) Co-authored-by: Musale Martin <martinmusale@microsoft.com> * docs: fix proxy provider sample readme (#1759) Clarifies the supported account types that can be used Updates flow of instructions to align to portal updates Fixes port used launchSettings when running from command line Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> * Fix freezing tabs on Safari (#1770) Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> * Add group-ids attribute to the people-picker component (#1652) Co-authored-by: Nickii Miaro <miaronkirote@gmail.com> Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> * fix: change sppkg details for mgt-spfx Updates the sppkg file name to use the pattern mgt-spfx-v{majorVersion}.sppkg Updates the solution name to "Microsoft Graph Toolkit v2 for SPFx" Co-authored-by: Gavin Barron <gavinbarron@microsoft.com> * fix: prevent unsafe access to dom nodes in getDocumentDirection (#1788) If a provider is in the head using mgt-loader the synchronous loading of mgt scripts causes LocaliztionHelper to attempt to access the body DOM node of the document before the browser has parsed the entire document causing body to be null. Using optional chaining avoids trying to call a method on a null object. * Bump Newtonsoft.Json from 11.0.1 to 13.0.1 in /samples/proxy-provider-asp-net-mvc/graph-tutorial (#1733) * Bump Newtonsoft.Json Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 11.0.1 to 13.0.1. - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@11.0.1...13.0.1) --- updated-dependencies: - dependency-name: Newtonsoft.Json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Updated assembly binding redirect to fix broken sample application Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gavin Barron <gavinbarron@microsoft.com> * fix: email resolution on paste for people picker (#1791) Closes #1763 Adds special handling for keyUp when pasting to resolve email addresses * Revert move of getUsers, fixes #1795 (#1798) Co-authored-by: Anders Roos <Anders.roos@nethouse.se> * Clear defaultPeople on forced state update, fixes #1796 (#1799) Co-authored-by: Anders Roos <Anders.roos@nethouse.se> * msal2 multi-account UI (#1041) * Added electron app * delete * Added electron sample folder * Added electron sample folder * Added electron sample folder * added electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Update README.md * Added license * Cleaned up license * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update samples/electron-app/package.json Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Review comments & removed cache plugin * Update packages/providers/mgt-electron-provider/src/Authenticator/CustomFileProtocol.ts Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Changed initialization of ElectronAuthenticator * updated sample readme * Update README.md * Removed all evidence of incremental consent support :P * Warning * MSAL2.0 * msal2 silent * Added msal2 custom element and sso * SSO fix * Added event on account switch * Fixed issue with setActiveAccount related to latest msal-browser package * Bumped up package version * temp fix * Single account * Added new test file * Update msal2-provider-test.html * Single account changes * Comments * Added msal2.0 provider to index.html * Added msal2.0 provider to index.html * enabled multi account * handle account changes in providers namespace * Comments * Revert "enabled multi account" This reverts commit 7f94528. * fixed binding issue * cleanup * fixed when unsubscribing * Added docs and removed account object * fixed bugs and enabled multi login * swapped provider and disabled cache * updated login ui using fluent listbox * ui and svg * arrow selection * fix hover for first selected item * profile size, spacing * fix package.json * hover state css * adds max-width, overflow for names * fixing spacing * Changes to mgt-login to store person image (#1046) Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * Changes to mgt-login part 2 (#1047) * Changes to mgt-login to store person image * PR comments Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * additional handling for overflow * tab indexing too * Update packages/mgt-components/src/components/mgt-login/mgt-login.ts Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Addressed PR comments (#1048) * Changes to mgt-login to store person image * PR comments * PR comments Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * Update packages/mgt-components/src/components/mgt-login/mgt-login.ts * handling for single user login and one user signed in multiuser * updating avatar-direction to person-flex-direction Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Shane Weaver <shweaver@microsoft.com> Co-authored-by: amrutha95 <amrutha.srinivasan95@gmail.com> Co-authored-by: Nikola Metulev <nikolame@microsoft.com> * Added multi-user cache functionality and enabled multi user login in Msal2Provider (#1299) Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Nicolas Vogt <NicolasVogt@TGSADMINs-MacBook-Pro.local> * [Fluent-UI][person-card] fluent controls upgrade (#1253) Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: Nicolas Vogt <NicolasVogt@TGSADMINs-MacBook-Pro.local> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Updated Graph Client to v3 (#1040) * updated Graph Client to v3.0.0 for all packages * Update README.md * updated login ui using fluent listbox * Update fluentui registration code * chore: Update aria-labels for base-icons * fix: font on email and chat labels * chore: bump fluentui to latest Co-authored-by: Nikola Metulev <nikolame@microsoft.com> Co-authored-by: Nicolas Vogt <nicolasjvogt@gmail.com> Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Shane Weaver <shweaver@microsoft.com> Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: André Lage <ponto_portuca@hotmail.com> Co-authored-by: Musale Martin <martinmusale@microsoft.com> Co-authored-by: Kyle <kylelobsinger@gmail.com> Co-authored-by: Gavin Barron <gavinbarron@microsoft.com> * [person]: Update person component to latest Fluent UI design (#1773) * update horizontal design * update person pill * fix user presence * update unauthenticated user design, fix avatar styles and accessibility * add vertical layout, fix presence, update pill * fix unauthenticated with email design * fix line2property on vertical layout * update person events and templating stories * fix view spacings, update rtl * fix vertical display * fix avatar-text spacings * remove comments, add file story * fix colour contrast * update vertical stylings * fix black person on person-card, update line2 property on login * Set the aria-label text for the buttons (#1708) * Set the aria-label for the button This allows the login component to have an encapsulating button which has an aria-label that is set depending on whether a user is signed in (sets the displayName) or signed out (sets the 'Sign In' string). * Check for a provider for storybook use case * Check the provider exists before checking the state on it * Set the aria-label for custom strings * Added aria-label text for buttons in person-card * [Person] fixed issue 1579 (#1682) * fixed issue #1579 * Adding object-fit and position to avoid stretch Co-authored-by: Musale Martin <martinmusale@microsoft.com> Co-authored-by: Nickii Miaro <miaronkirote@gmail.com> Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> Co-authored-by: Sébastien Levert <slevert@outlook.com> * fix build * update: fix rebase and style issues * update: use variables for style colors * update: adds in story for rendered icon when initials not available * update: use variable for wrapper hover * update: fix user presence Co-authored-by: Musale Martin <martinmusale@microsoft.com> Co-authored-by: wuxiaojun514 <wuxiaojun514@163.com> Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> Co-authored-by: Sébastien Levert <slevert@outlook.com> * fix build after rebase Co-authored-by: Musale Martin <martinmusale@microsoft.com> Co-authored-by: rentu <5545529+SLdragon@users.noreply.github.com> Co-authored-by: turenlong <rentu@microsoft.com> Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> Co-authored-by: Nicolas Vogt <nicolasjvogt@gmail.com> Co-authored-by: Waldek Mastykarz <waldek@mastykarz.nl> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Elinor <elkaguon@microsoft.com> Co-authored-by: Elinor <ekaguongo@gmail.com> Co-authored-by: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Co-authored-by: Gavin Barron <gavin.barron@gmail.com> Co-authored-by: Gavin Barron <gavinbarron@microsoft.com> Co-authored-by: Hilton Giesenow <hilton@giesenow.com> Co-authored-by: Anders Roos <malakeen@gmail.com> Co-authored-by: Anders Roos <Anders.roos@nethouse.se> Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Shane Weaver <shweaver@microsoft.com> Co-authored-by: amrutha95 <amrutha.srinivasan95@gmail.com> Co-authored-by: Nikola Metulev <nikolame@microsoft.com> Co-authored-by: Nicolas Vogt <NicolasVogt@TGSADMINs-MacBook-Pro.local> Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: André Lage <ponto_portuca@hotmail.com> Co-authored-by: Kyle <kylelobsinger@gmail.com> Co-authored-by: wuxiaojun514 <wuxiaojun514@163.com> Co-authored-by: Sébastien Levert <slevert@outlook.com>
Mnickii
pushed a commit
that referenced
this pull request
Sep 8, 2022
* Added electron app * delete * Added electron sample folder * Added electron sample folder * Added electron sample folder * added electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Update README.md * Added license * Cleaned up license * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update samples/electron-app/package.json Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Review comments & removed cache plugin * Update packages/providers/mgt-electron-provider/src/Authenticator/CustomFileProtocol.ts Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Changed initialization of ElectronAuthenticator * updated sample readme * Update README.md * Removed all evidence of incremental consent support :P * Warning * MSAL2.0 * msal2 silent * Added msal2 custom element and sso * SSO fix * Added event on account switch * Fixed issue with setActiveAccount related to latest msal-browser package * Bumped up package version * temp fix * Single account * Added new test file * Update msal2-provider-test.html * Single account changes * Comments * Added msal2.0 provider to index.html * Added msal2.0 provider to index.html * enabled multi account * handle account changes in providers namespace * Comments * Revert "enabled multi account" This reverts commit 7f94528. * fixed binding issue * cleanup * fixed when unsubscribing * Added docs and removed account object * fixed bugs and enabled multi login * swapped provider and disabled cache * updated login ui using fluent listbox * ui and svg * arrow selection * fix hover for first selected item * profile size, spacing * fix package.json * hover state css * adds max-width, overflow for names * fixing spacing * Changes to mgt-login to store person image (#1046) Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * Changes to mgt-login part 2 (#1047) * Changes to mgt-login to store person image * PR comments Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * additional handling for overflow * tab indexing too * Update packages/mgt-components/src/components/mgt-login/mgt-login.ts Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Addressed PR comments (#1048) * Changes to mgt-login to store person image * PR comments * PR comments Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * Update packages/mgt-components/src/components/mgt-login/mgt-login.ts * handling for single user login and one user signed in multiuser * updating avatar-direction to person-flex-direction Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Shane Weaver <shweaver@microsoft.com> Co-authored-by: amrutha95 <amrutha.srinivasan95@gmail.com> Co-authored-by: Nikola Metulev <nikolame@microsoft.com>
Mnickii
added a commit
that referenced
this pull request
Sep 8, 2022
* Set the aria-label text for the buttons (#1708) * Set the aria-label for the button This allows the login component to have an encapsulating button which has an aria-label that is set depending on whether a user is signed in (sets the displayName) or signed out (sets the 'Sign In' string). * Check for a provider for storybook use case * Check the provider exists before checking the state on it * Set the aria-label for custom strings * Added aria-label text for buttons in person-card * [mgt-teamsfx-provider] update peer dependency to support teamsfx sdk 1.x.x (#1722) Co-authored-by: turenlong <rentu@microsoft.com> * Adding the spec for mgt-picker v2. (#1714) Co-authored-by: Musale Martin <martinmusale@microsoft.com> * Allow tab navigation to be lockable within the person-card (#1726) * Add tab navigation locking to the person card * Allow tabbing navigation to be lockable in person-card * Add generated react file * Adding TeamsFx to the Overview page (#1738) * [accessibility] fix keyboard controls in localization (#1720) Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> * [mgt-person-card] Accessibility, zoom or window height minimums for content (#1731) Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> * Updates mgt-spfx to SPFx@1.15.0 (#1742) * Bump Newtonsoft.Json in /samples/proxy-provider-asp-net-core (#1732) Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.3 to 13.0.1. - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@12.0.3...13.0.1) --- updated-dependencies: - dependency-name: Newtonsoft.Json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update role to searchbox (#1757) Co-authored-by: Musale Martin <martinmusale@microsoft.com> * Update aria-roles and add aria-labels (#1761) * update aria-roles and add aria-labels * add aria-label * chore: Add `.github/fabricbot.json` (#1734) Co-authored-by: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Co-authored-by: Gavin Barron <gavin.barron@gmail.com> * chore(deps): update sample angular app dependencies (#1762) * Rebuilt package-lock.json to address security advisories * bumping @anglar/cli to v10 * bumping to Angular 10 * Bumping to Angular 11 and updating tailwind config * downgrade tailwind for ng update * updated package-lock for tailwind downgrade * Bumping to Angular 12 * Bumping @angular-builders/custom-webpack to match angular version Co-authored-by: Musale Martin <martinmusale@microsoft.com> * Update TeamsFx Provider README.md (#1755) Co-authored-by: Musale Martin <martinmusale@microsoft.com> * docs: fix proxy provider sample readme (#1759) Clarifies the supported account types that can be used Updates flow of instructions to align to portal updates Fixes port used launchSettings when running from command line Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> * Fix freezing tabs on Safari (#1770) Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> * Add group-ids attribute to the people-picker component (#1652) Co-authored-by: Nickii Miaro <miaronkirote@gmail.com> Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> * fix: change sppkg details for mgt-spfx Updates the sppkg file name to use the pattern mgt-spfx-v{majorVersion}.sppkg Updates the solution name to "Microsoft Graph Toolkit v2 for SPFx" Co-authored-by: Gavin Barron <gavinbarron@microsoft.com> * fix: prevent unsafe access to dom nodes in getDocumentDirection (#1788) If a provider is in the head using mgt-loader the synchronous loading of mgt scripts causes LocaliztionHelper to attempt to access the body DOM node of the document before the browser has parsed the entire document causing body to be null. Using optional chaining avoids trying to call a method on a null object. * Bump Newtonsoft.Json from 11.0.1 to 13.0.1 in /samples/proxy-provider-asp-net-mvc/graph-tutorial (#1733) * Bump Newtonsoft.Json Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 11.0.1 to 13.0.1. - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@11.0.1...13.0.1) --- updated-dependencies: - dependency-name: Newtonsoft.Json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Updated assembly binding redirect to fix broken sample application Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gavin Barron <gavinbarron@microsoft.com> * fix: email resolution on paste for people picker (#1791) Closes #1763 Adds special handling for keyUp when pasting to resolve email addresses * Revert move of getUsers, fixes #1795 (#1798) Co-authored-by: Anders Roos <Anders.roos@nethouse.se> * Clear defaultPeople on forced state update, fixes #1796 (#1799) Co-authored-by: Anders Roos <Anders.roos@nethouse.se> * msal2 multi-account UI (#1041) * Added electron app * delete * Added electron sample folder * Added electron sample folder * Added electron sample folder * added electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Electron provider * Update README.md * Added license * Cleaned up license * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update samples/electron-app/package.json Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Update packages/providers/mgt-electron-provider/README.md Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Review comments & removed cache plugin * Update packages/providers/mgt-electron-provider/src/Authenticator/CustomFileProtocol.ts Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Changed initialization of ElectronAuthenticator * updated sample readme * Update README.md * Removed all evidence of incremental consent support :P * Warning * MSAL2.0 * msal2 silent * Added msal2 custom element and sso * SSO fix * Added event on account switch * Fixed issue with setActiveAccount related to latest msal-browser package * Bumped up package version * temp fix * Single account * Added new test file * Update msal2-provider-test.html * Single account changes * Comments * Added msal2.0 provider to index.html * Added msal2.0 provider to index.html * enabled multi account * handle account changes in providers namespace * Comments * Revert "enabled multi account" This reverts commit 7f94528. * fixed binding issue * cleanup * fixed when unsubscribing * Added docs and removed account object * fixed bugs and enabled multi login * swapped provider and disabled cache * updated login ui using fluent listbox * ui and svg * arrow selection * fix hover for first selected item * profile size, spacing * fix package.json * hover state css * adds max-width, overflow for names * fixing spacing * Changes to mgt-login to store person image (#1046) Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * Changes to mgt-login part 2 (#1047) * Changes to mgt-login to store person image * PR comments Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * additional handling for overflow * tab indexing too * Update packages/mgt-components/src/components/mgt-login/mgt-login.ts Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Addressed PR comments (#1048) * Changes to mgt-login to store person image * PR comments * PR comments Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> * Update packages/mgt-components/src/components/mgt-login/mgt-login.ts * handling for single user login and one user signed in multiuser * updating avatar-direction to person-flex-direction Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Shane Weaver <shweaver@microsoft.com> Co-authored-by: amrutha95 <amrutha.srinivasan95@gmail.com> Co-authored-by: Nikola Metulev <nikolame@microsoft.com> * Added multi-user cache functionality and enabled multi user login in Msal2Provider (#1299) Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Nicolas Vogt <NicolasVogt@TGSADMINs-MacBook-Pro.local> * [Fluent-UI][person-card] fluent controls upgrade (#1253) Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: Nicolas Vogt <NicolasVogt@TGSADMINs-MacBook-Pro.local> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> * Updated Graph Client to v3 (#1040) * updated Graph Client to v3.0.0 for all packages * Update README.md * updated login ui using fluent listbox * Update fluentui registration code * chore: Update aria-labels for base-icons * fix: font on email and chat labels * chore: bump fluentui to latest Co-authored-by: Nikola Metulev <nikolame@microsoft.com> Co-authored-by: Nicolas Vogt <nicolasjvogt@gmail.com> Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Shane Weaver <shweaver@microsoft.com> Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: André Lage <ponto_portuca@hotmail.com> Co-authored-by: Musale Martin <martinmusale@microsoft.com> Co-authored-by: Kyle <kylelobsinger@gmail.com> Co-authored-by: Gavin Barron <gavinbarron@microsoft.com> * [person]: Update person component to latest Fluent UI design (#1773) * update horizontal design * update person pill * fix user presence * update unauthenticated user design, fix avatar styles and accessibility * add vertical layout, fix presence, update pill * fix unauthenticated with email design * fix line2property on vertical layout * update person events and templating stories * fix view spacings, update rtl * fix vertical display * fix avatar-text spacings * remove comments, add file story * fix colour contrast * update vertical stylings * fix black person on person-card, update line2 property on login * Set the aria-label text for the buttons (#1708) * Set the aria-label for the button This allows the login component to have an encapsulating button which has an aria-label that is set depending on whether a user is signed in (sets the displayName) or signed out (sets the 'Sign In' string). * Check for a provider for storybook use case * Check the provider exists before checking the state on it * Set the aria-label for custom strings * Added aria-label text for buttons in person-card * [Person] fixed issue 1579 (#1682) * fixed issue #1579 * Adding object-fit and position to avoid stretch Co-authored-by: Musale Martin <martinmusale@microsoft.com> Co-authored-by: Nickii Miaro <miaronkirote@gmail.com> Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> Co-authored-by: Sébastien Levert <slevert@outlook.com> * fix build * update: fix rebase and style issues * update: use variables for style colors * update: adds in story for rendered icon when initials not available * update: use variable for wrapper hover * update: fix user presence Co-authored-by: Musale Martin <martinmusale@microsoft.com> Co-authored-by: wuxiaojun514 <wuxiaojun514@163.com> Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> Co-authored-by: Sébastien Levert <slevert@outlook.com> * fix build after rebase Co-authored-by: Musale Martin <martinmusale@microsoft.com> Co-authored-by: rentu <5545529+SLdragon@users.noreply.github.com> Co-authored-by: turenlong <rentu@microsoft.com> Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> Co-authored-by: Nicolas Vogt <nicolasjvogt@gmail.com> Co-authored-by: Waldek Mastykarz <waldek@mastykarz.nl> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Elinor <elkaguon@microsoft.com> Co-authored-by: Elinor <ekaguongo@gmail.com> Co-authored-by: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Co-authored-by: Gavin Barron <gavin.barron@gmail.com> Co-authored-by: Gavin Barron <gavinbarron@microsoft.com> Co-authored-by: Hilton Giesenow <hilton@giesenow.com> Co-authored-by: Anders Roos <malakeen@gmail.com> Co-authored-by: Anders Roos <Anders.roos@nethouse.se> Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Shane Weaver <shweaver@microsoft.com> Co-authored-by: amrutha95 <amrutha.srinivasan95@gmail.com> Co-authored-by: Nikola Metulev <nikolame@microsoft.com> Co-authored-by: Nicolas Vogt <NicolasVogt@TGSADMINs-MacBook-Pro.local> Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: André Lage <ponto_portuca@hotmail.com> Co-authored-by: Kyle <kylelobsinger@gmail.com> Co-authored-by: wuxiaojun514 <wuxiaojun514@163.com> Co-authored-by: Sébastien Levert <slevert@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
PR Type
Description of the changes
PR checklist
yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense)Other information