Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Update agenda component to the fluent UI spec #1867

Merged
merged 50 commits into from
Feb 24, 2023
Merged

feature: Update agenda component to the fluent UI spec #1867

merged 50 commits into from
Feb 24, 2023

Conversation

musale
Copy link
Contributor

@musale musale commented Sep 27, 2022 •
edited

Closes #1624

PR Type

  • Feature

Description of the changes

  • Updates the agenda component to the fluent UI spec.
  • Fixes a bug with the people component when it returns null people values that fail when you try to get the id.
  • Adds a new CSS property --event-row-gap that allows a developer to customize the size between two event elements. This property deprecates the --event-margin property.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@musale musale added this to the v3.0.0 milestone Sep 27, 2022
@ghost
Copy link

ghost commented Sep 27, 2022

Thank you for creating a Pull Request @musale.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

The updated storybook is available here

2 similar comments
@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

gavinbarron
gavinbarron requested changes Oct 11, 2022
View reviewed changes
Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've yet to do a good review of the appearance, but there's a few little things that stood out.

packages/mgt-components/src/components/mgt-agenda/mgt-agenda.ts Outdated Show resolved Hide resolved
packages/mgt-components/src/components/mgt-agenda/mgt-agenda.ts Outdated Show resolved Hide resolved
packages/mgt-components/src/components/mgt-people/mgt-people.ts Outdated Show resolved Hide resolved
packages/mgt-components/src/graph/graph.presence.ts Outdated Show resolved Hide resolved
@ghost ghost added the Needs: Author Feedback Issue needs response from issue author label Oct 11, 2022
@github-actions
Copy link

The updated storybook is available here

@ghost ghost removed the Needs: Author Feedback Issue needs response from issue author label Oct 12, 2022
@musale
Merge branch 'musale/fluentui/agenda' of github.com:microsoftgraph/mi…
5bacf25 
…crosoft-graph-toolkit into musale/fluentui/agenda
@ghost ghost added the Needs: Author Feedback Issue needs response from issue author label Jan 23, 2023
@github-actions
Copy link

The updated storybook is available here

@musale @gavinbarron
fix: smaller layouts width
63bddcb 
Co-authored-by: Gavin Barron <gavinbarron@microsoft.com>
@ghost ghost removed the Needs: Author Feedback Issue needs response from issue author label Jan 30, 2023
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

The updated storybook is available here

@ghost ghost added the Needs: Author Feedback Issue needs response from issue author label Feb 8, 2023
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

The updated storybook is available here

@ghost ghost removed the Needs: Author Feedback Issue needs response from issue author label Feb 13, 2023
@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

gavinbarron
gavinbarron approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

@musale musale merged commit 2771544 into next/fluentui Feb 24, 2023
@musale musale deleted the musale/fluentui/agenda branch February 24, 2023 08:46
This was referenced Jul 17, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinbarron gavinbarron gavinbarron approved these changes

@sebastienlevert sebastienlevert sebastienlevert approved these changes

@Mnickii Mnickii Awaiting requested review from Mnickii

@yejuntak yejuntak Awaiting requested review from yejuntak

Assignees

@musale musale

Labels
Build: Storybook
Projects
Graph Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agenda component should be updated to the latest Fluent UI design
4 participants
@musale @gavinbarron @sebastienlevert @yejuntak