Adding support for assigning people in tasks and much more #188

vogtn · 2019-10-18T20:27:20Z

PR Type

Bugfix
Feature

Description of the changes

New features:

mgt-tasks:
- users can now select assigned people or update existing tasks with assigned people
- assigned people now have a person-card on hover

Bug fixes:

A fix for when removing people from mgt-people-picker or mgt-people, the image for the people was not updating.

New properties, events, templates:

mgt-people:
- no-people template
- person-card attribute
- user-ids attribute
mgt-tasks
- task template
- task-details template
- isNewTaskVisible property (thanks @BenjiFischman)
- taskClick event

General cleanup of code and styles for mgt-tasks

PR checklist

Added tests and all passed
All public classes and methods have been documented
Added appropriate documentation
License header has been added to all new source files
Contains NO breaking changes

Other information

… for handling render of people-picker

…osoftgraph/microsoft-graph-toolkit into nivogt/v2/task-peoplepicker

nmetulev

The +1 in the people looks weird in tasks
Clicking on the people in tasks when people picker is open should close the people picker
If people in people-picker don't change, then the task should not be updated - now it updates every time the people picker is closed and sometimes graph errors show up
person-card is enabled for people in new task

src/Graph.ts

…osoftgraph/microsoft-graph-toolkit into nivogt/v2/task-peoplepicker

vogtn · 2019-11-01T15:42:35Z

The +1 in the people looks weird in tasks

fixed, and spacing between calendar: fa32cdc

person-card is enabled for people in new task

removed: 933c4bc

If people in people-picker don't change, then the task should not be updated - now it updates every time the people picker is closed and sometimes graph errors show up

updated: 240d371

…ot to update

nmetulev

Few more comments

the taskClick event is only fired when a click on the people - the oposite should be true. The event should fire when I click on the task anywhere (except areas where there is an action/button - people, completing, options, etc)
I get an exception when changing the assignment of a task:

nmetulev · 2019-11-01T19:26:33Z

src/components/mgt-tasks/mgt-tasks.ts

-        this._currentTargetDresser = this.initialId;
-      } else if (this.dataSource === 'todo') {
-        this._currentTargetDrawer = this.initialId;
+    window.addEventListener('click', (event: MouseEvent) => {


Per lit-element docs, events on window should be set up in connectedCallback and removed in disconnectedCallback.

If your component adds an event listener to anything except itself or its children–for example, to Window, Document, or some element in the main DOM–you should add the listener in connectedCallback and remove it in disconnectedCallback.

src/components/mgt-tasks/mgt-tasks.ts

nmetulev · 2019-11-01T19:37:01Z

src/components/mgt-tasks/mgt-tasks.ts

+    if (picker) {
+      for (const person of picker.selectedPeople) {
+        if (picker.selectedPeople.length) {
+          peopleObj[person.id] = { '@odata.type': 'microsoft.graph.plannerAssignment', orderHint: 'string !' };


You are using this object in multiple places - makes sense to define it once and reuse it

Refactored peopleObj: 3d33dd2

sorry, should have been more clear, I meant the {'odata.type.... object

src/components/mgt-tasks/mgt-tasks.ts

src/components/mgt-tasks/task-sources.ts

…hange

vogtn · 2019-11-02T02:05:00Z

the taskClick event is only fired when a click on the people - the oposite should be true. The event should fire when I click on the task anywhere (except areas where there is an action/button - people, completing, options, etc)

fixed here: ef2c2d9

vogtn · 2019-11-02T02:39:52Z

Clicking on the people in tasks when people picker is open should close the people picker

fixed here: bc6bf22

* people-picker in task component basic functionality. TODO: filter people * [mgt-task] fixing styles of picker * [mgt-tasks] default state if nobody is assigned * fixing errors * [mgt-tasks] adding deletion or removing selected people * [Graph] adding assign people promise to planner * always show assigned to me * renamed drawers and dressers * filtering of tasks when target-id is set and clean up of mgt-tasks * added tasks templates and fied styles and utils * [mgt-tasks] updating method for handling people picker hiding * updating picker styles * [mgt-task] fixing null selected people case * [mgt-tasks] updating styles for better scss scaffolding and new logic for handling render of people-picker * task source documentation * [mgt-tasks] assings to default if no people are provided * [mgt-tasks] picker on new task issue * adding property to mgt-people for user id selectionfor use in tasks * minor layout fix for new task * [mgt-people] adding personCardInteraction property to people * restoring index.html * [mgt-people] adding 'no-people' template * [mgt-tasks] updating task and picker to inherit people from each other * [PersonCardInteraction] refactoring personcard interactions for specific definitions of hover and click for task components * removing and updating necessary imports * [mgt-people] refactor peopleid promise into promise.all * [mgt-tasks mgt-people] removed default html for no-people and moved template to task. updated picker hiding method * [mgt-tasks] adding taskClick custom event * fixed default person card on people * Added setter and getter for property isNewTaskVisible * [Graph.ts] changing order of assignPeopleToTask parameters * [mgt-tasks] fixing mgt-people styles * [mgt-tasks] disabled person-card inside of newTask people * [mgt-tasks] adding isEqual if picker chosen people aren't different not to update * assingPeopletoTask rather than person * rename nopeople template and click handler * Fix for images in people and people-picker not updating when people change * fix for person card in tasks * [mgt-tasks] refactor show and hid picker, removing self assigned task * [mgt-tasks] refactor peopleObj * [mgt-tasks] fixing typing in assign people and sort * [mgt-tasks] re-work of taskClick event * [mgt-tasks] allowing click on people to save and hide people-picker * update taskClick event with raw task results, and minor fixes

vogtn and others added 17 commits October 16, 2019 08:16

people-picker in task component basic functionality. TODO: filter people

419781b

[mgt-task] fixing styles of picker

1723cbd

[mgt-tasks] default state if nobody is assigned

9e99158

fixing errors

3b006ab

Merge branch 'master' into nivogt/task-people-picker

3de1d39

[mgt-tasks] adding deletion or removing selected people

1fe8ee2

[Graph] adding assign people promise to planner

46ef440

always show assigned to me

0d57af7

renamed drawers and dressers

5c8d134

Merge branch 'nmetulev/tasks' into nmetulev/v2/task-peoplepicker

b983850

filtering of tasks when target-id is set and clean up of mgt-tasks

2fd537e

added tasks templates and fied styles and utils

6bcc629

[mgt-tasks] updating method for handling people picker hiding

9a30c07

merge

c4a928a

updating picker styles

2e77eb8

[mgt-task] fixing null selected people case

53b59c1

Merge branch 'master' into nivogt/v2/task-peoplepicker

b980b19

nmetulev mentioned this pull request Oct 18, 2019

integration of people-picker in task component #180

Closed

5 tasks

vogtn and others added 12 commits October 18, 2019 17:32

[mgt-tasks] updating styles for better scss scaffolding and new logic…

45dc99a

… for handling render of people-picker

Merge branch 'nivogt/v2/task-peoplepicker' of https://github.com/micr…

4345a6a

…osoftgraph/microsoft-graph-toolkit into nivogt/v2/task-peoplepicker

task source documentation

5cc4106

[mgt-tasks] assings to default if no people are provided

b1fb969

[mgt-tasks] picker on new task issue

b00af85

adding property to mgt-people for user id selectionfor use in tasks

d0d31e1

minor layout fix for new task

8ad3216

Merge branch 'master' into nivogt/v2/task-peoplepicker

857b6ad

merged master

2387f54

[mgt-people] adding personCardInteraction property to people

6fe23c9

Merge branch 'nivogt/v2/task-peoplepicker' of https://github.com/micr…

635dd8a

…osoftgraph/microsoft-graph-toolkit into nivogt/v2/task-peoplepicker

restoring index.html

1d67f9d

fixed default person card on people

329c39f

nmetulev reviewed Oct 31, 2019

View reviewed changes

src/Graph.ts Outdated Show resolved Hide resolved

BenjiFischman and others added 4 commits October 31, 2019 16:53

Added setter and getter for property isNewTaskVisible

001c3a2

Merge branch 'nivogt/v2/task-peoplepicker' of https://github.com/micr…

1c3221a

…osoftgraph/microsoft-graph-toolkit into nivogt/v2/task-peoplepicker

[Graph.ts] changing order of assignPeopleToTask parameters

c1b04e8

[mgt-tasks] fixing mgt-people styles

fa32cdc

vogtn added 2 commits November 1, 2019 09:00

[mgt-tasks] disabled person-card inside of newTask people

933c4bc

[mgt-tasks] adding isEqual if picker chosen people aren't different n…

240d371

…ot to update

nmetulev reviewed Nov 1, 2019

View reviewed changes

vogtn and others added 4 commits November 1, 2019 14:14

assingPeopletoTask rather than person

02aa630

rename nopeople template and click handler

00897b2

Fix for images in people and people-picker not updating when people c…

c4e0373

…hange

fix for person card in tasks

db03d9b

nmetulev changed the title ~~Nivogt/v2/task peoplepicker~~ Adding support for assigning people in tasks and much more Nov 1, 2019

vogtn added 4 commits November 1, 2019 15:27

[mgt-tasks] refactor show and hid picker, removing self assigned task

76741d3

[mgt-tasks] refactor peopleObj

3d33dd2

[mgt-tasks] fixing typing in assign people and sort

566e22e

[mgt-tasks] re-work of taskClick event

ef2c2d9

[mgt-tasks] allowing click on people to save and hide people-picker

bc6bf22

update taskClick event with raw task results, and minor fixes

c7b984f

nmetulev approved these changes Nov 2, 2019

View reviewed changes

nmetulev merged commit cce5746 into master Nov 2, 2019

nmetulev deleted the nivogt/v2/task-peoplepicker branch November 2, 2019 04:32

nmetulev mentioned this pull request Nov 2, 2019

[docs] missing docs (v1.1) #184

Closed

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding support for assigning people in tasks and much more #188

Adding support for assigning people in tasks and much more #188

vogtn commented Oct 18, 2019 •

edited by nmetulev

nmetulev left a comment

vogtn commented Nov 1, 2019 •

edited

nmetulev left a comment

nmetulev Nov 1, 2019

nmetulev Nov 1, 2019

vogtn Nov 1, 2019

nmetulev Nov 2, 2019

vogtn commented Nov 2, 2019

vogtn commented Nov 2, 2019

Adding support for assigning people in tasks and much more #188

Adding support for assigning people in tasks and much more #188

Conversation

vogtn commented Oct 18, 2019 • edited by nmetulev

PR Type

Description of the changes

PR checklist

Other information

nmetulev left a comment

Choose a reason for hiding this comment

vogtn commented Nov 1, 2019 • edited

nmetulev left a comment

Choose a reason for hiding this comment

nmetulev Nov 1, 2019

Choose a reason for hiding this comment

nmetulev Nov 1, 2019

Choose a reason for hiding this comment

vogtn Nov 1, 2019

Choose a reason for hiding this comment

nmetulev Nov 2, 2019

Choose a reason for hiding this comment

vogtn commented Nov 2, 2019

vogtn commented Nov 2, 2019

vogtn commented Oct 18, 2019 •

edited by nmetulev

vogtn commented Nov 1, 2019 •

edited