Fix for templates not rendering children in the right order #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed data context to person-card templates
vogtn
approved these changes
Nov 4, 2019
shweaver-MSFT
pushed a commit
that referenced
this pull request
Jun 8, 2020
Fix for templates not rendering children in the right order
shweaver-MSFT
pushed a commit
that referenced
this pull request
Jun 10, 2020
Fix for templates not rendering children in the right order
shweaver-MSFT
pushed a commit
that referenced
this pull request
Jun 10, 2020
Fix for templates not rendering children in the right order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Description of the changes
This pr fixes an issue where a
data-forloop is used in a template and items are rendered out of order.This pr also adds the personDetails and personImage in the context of the templates in the person-card component