Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add quick messaging to fluent person-card #1958

Merged
merged 42 commits into from
Mar 2, 2023
Merged

feat: add quick messaging to fluent person-card #1958

merged 42 commits into from
Mar 2, 2023

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Nov 17, 2022

Closes #1957

PR Type

Feature

Description of the changes

Adds a quick message section to the person-card overview.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Nov 17, 2022

Thank you for creating a Pull Request @Mnickii.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@Mnickii Mnickii linked an issue Nov 17, 2022 that may be closed by this pull request
Add quick message to new person card fluent design #1957
Closed
@Mnickii Mnickii added this to the 2022-11 milestone Nov 17, 2022
@github-actions
Copy link

The updated storybook is available here

@sebastienlevert
Copy link
Contributor

I can't find the message box :

image

@Mnickii
Copy link
Collaborator Author

Mnickii commented Nov 17, 2022 •
edited

chat
@sebastienlevert I thought to remove the message section when the person card shows the logged in user. But if the user accesses other person cards, then they can send a quick message to them. The chat resource doesn't allow for duplication of the members.

@sebastienlevert
Copy link
Contributor

sebastienlevert commented Nov 17, 2022 •
edited

Very good point! I'm all good with this then! In this case, I'd remove the double "line" at the top of the card

image

@github-actions
Copy link

The updated storybook is available here

@sebastienlevert
Copy link
Contributor

sebastienlevert commented Nov 17, 2022 •
edited

From an experience standpoint (I can't test if this is really "sent" because of the sandbox):

  • When hitting enter, it should send (should we have a check confirming message was sent?
  • When sending a message, the previous message should be removed from the textbox
  • Text should be "Send a quick message" to reflect Teams default message.

Example from Teams

image
image
image

@sebastienlevert
Copy link
Contributor

Dark mode definitely needs to be reviewed :

image

@gavinbarron gavinbarron modified the milestones: 2022-11, v3.0.0 Nov 28, 2022
@sebastienlevert sebastienlevert removed this from the v3.0.0 milestone Nov 29, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

The updated storybook is available here

sebastienlevert
sebastienlevert requested changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messages don't work on any of the story I've been trying. Rest looks good to me!

@ghost ghost added the Needs: Author Feedback Issue needs response from issue author label Dec 8, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

The updated storybook is available here

@gavinbarron
Copy link
Member

Messages don't work on any of the story I've been trying. Rest looks good to me!

@sebastienlevert they're sending for me, but with no affordance in the UI that they were sent.

@sebastienlevert
Copy link
Contributor

@sebastienlevert they're sending for me, but with no affordance in the UI that they were sent.

@gavinbarron I didn't mean sending messages. I mean I can't see the tab with the emails between me and the user. Also, good catch, I get the same. I noted the issue in an earlier comment #1958 (comment)

@gavinbarron
Copy link
Member

@gavinbarron I didn't mean sending messages. I mean I can't see the tab with the emails between me and the user

Ahh, gotcha, so many types of messages.

@gavinbarron
Copy link
Member

@sebastienlevert they're sending for me, but with no affordance in the UI that they were sent.

@gavinbarron I didn't mean sending messages. I mean I can't see the tab with the emails between me and the user. Also, good catch, I get the same. I noted the issue in an earlier comment #1958 (comment)

I've taken a look at this and I think that it's fine. This section renders messages that the user viewing the card has received from the user being rendered. It uses Mail.ReadBasic.

`me/messages?$search="from:${emailAddress}"`, ['Mail.ReadBasic'])`

The default user in the MockProvider only has 1 email that isn't Analytics/Viva/Outlook sent, and it's from themselves!

In my test tenant, signed in with the admin account I see emails from Megan that she sent to a Group the admin is part of:
image

The Files Tab has a similar behavior where it doesn't show if there are no files to show.

@Mnickii Mnickii requested a review from musale February 17, 2023 14:15
@github-actions
Copy link

The updated storybook is available here

@ghost ghost added the Needs: Author Feedback Issue needs response from issue author label Feb 27, 2023
@Mnickii @gavinbarron
Update packages/mgt-components/src/components/mgt-person-card/mgt-per…
f79fdf4 
…son-card.ts

Co-authored-by: Gavin Barron <gavinbarron@microsoft.com>
@ghost ghost removed the Needs: Author Feedback Issue needs response from issue author label Mar 1, 2023
@Mnickii @gavinbarron
Update packages/mgt-components/src/components/mgt-person-card/mgt-per…
dc9cc9e 
…son-card.ts

Co-authored-by: Gavin Barron <gavinbarron@microsoft.com>
@sebastienlevert
Copy link
Contributor

@Mnickii where are we with this? It seems to be pending latest changes to be able to merge?

@Mnickii
Copy link
Collaborator Author

Mnickii commented Mar 2, 2023

@sebastienlevert It should be ready to go now

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

The updated storybook is available here

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

The updated storybook is available here

gavinbarron
gavinbarron approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@gavinbarron gavinbarron enabled auto-merge (squash) March 2, 2023 18:11
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

The updated storybook is available here

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

The updated storybook is available here

@gavinbarron gavinbarron merged commit 94e390b into next/fluentui Mar 2, 2023
@gavinbarron gavinbarron deleted the mnickii/person-card-fluent-quick-message branch March 2, 2023 18:54
This was referenced Jul 17, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinbarron gavinbarron gavinbarron approved these changes

@sebastienlevert sebastienlevert sebastienlevert approved these changes

@musale musale musale approved these changes

Assignees
No one assigned
Labels
Build: Storybook
Projects
Graph Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add quick message to new person card fluent design
5 participants
@Mnickii @sebastienlevert @gavinbarron @mohamedcherifmo @musale