Fixed issue where flyouts render outside of window bounds #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JustinXinLiu This changes the center point of the flyout of the card to match the center point of the respective person. See the screen shots below, what is your opinion?: Note: cursor position is over Adele Vance's Previous (offset): After (center): |
|
Looks good to me! |
vogtn
approved these changes
Nov 27, 2019
shweaver-MSFT
pushed a commit
that referenced
this pull request
Jun 8, 2020
Fixed issue where flyouts render outside of window bounds
shweaver-MSFT
pushed a commit
that referenced
this pull request
Jun 10, 2020
Fixed issue where flyouts render outside of window bounds
shweaver-MSFT
pushed a commit
that referenced
this pull request
Jun 10, 2020
Fixed issue where flyouts render outside of window bounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #202
PR Type
Description of the changes
This PR introduces a new internal component for rendering flyouts (
mgt-flyout) and replaces all code where we render a flyout (person-card in person, and people-picker in tasks). The new component helps to avoid re-implementing flyouts for every component that needs it and ensures all flyouts behave the same.mgt-flyout measures the content to render and ensures the flyout is fully visible on screen when possible.