Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new task select rendering #2368

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Conversation

gavinbarron
Copy link
Member

Closes #2316

PR Type

  • Bugfix

Description of the changes

ensures fluent components are properly registered
adds styling to wrap new task inputs when needed

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

ensures fluent components are properly registered
adds styling to wrap new task inputs when needed
@gavinbarron gavinbarron requested a review from a team as a code owner May 31, 2023 18:16
@ghost
Copy link

ghost commented May 31, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

The updated storybook is available here

Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sebastienlevert sebastienlevert enabled auto-merge (squash) June 1, 2023 16:56
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

The updated storybook is available here

@sebastienlevert sebastienlevert merged commit f55a88a into next/fluentui Jun 1, 2023
8 checks passed
@sebastienlevert sebastienlevert deleted the bug/todo-pickers branch June 1, 2023 17:15
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

The updated storybook is available here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] mgt-tasks: target list and state selectors rendering incorrectly
2 participants