fix: announce teams channel results when you type #2539

musale · 2023-06-23T16:07:36Z

Closes #2292

PR Type

Bugfix

Description of the changes

Announce the rendered results in the dropdown
Announce the filtered resutls in the drop down

PR checklist

Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
Stories have been added and existing stories have been tested
Added appropriate documentation. Docs PR:

License header has been added to all new source files (yarn setLicense)
Contains NO breaking changes

Other information

Signed-off-by: Martin Musale <martinmusale@microsoft.com>

ghost · 2023-06-23T16:07:43Z

Thank you for creating a Pull Request @musale.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

I have verified a documentation PR has been linked and is approved (or not applicable)
I have ran this PR locally and have tested the fix/feature
I have verified that stories have been added to storybook (or not applicable)
I have tested existing stories in storybook to verify no regression has occured
I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

…raph-toolkit into bug-2292

musale · 2023-06-23T16:13:13Z

@microsoft-graph-toolkit-write this should work BUT I have found an issue in handling the state of component. Visually, everything looks like it's working correctly. Using narrator, other bugs come up.

Repro 1

Open teams-channel-picker with narrator ON.
Focus on the input. This will announce the results CORRECTLY.
type a single letter. This will announce the filtered results CORRECTLY.
Type the second later. Nothing is announced.
Delete everything. Nothing is announced.

This is a different experience in the people-picker.

Any ideas to fix this experience are very welcome 😄

github-actions · 2023-06-23T16:18:29Z