Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added customHosts support #2592

Merged
merged 3 commits into from Jul 7, 2023
Merged

Conversation

techienickb
Copy link
Contributor

@techienickb techienickb commented Jul 6, 2023

Closes #2589

PR Type

Bugfix

Description of the changes

Adds option to pass through customHosts to the graph client to allow calling of non graph but AAD secured endpoints.

Because customHosts is a set, common Lib ES6 was added.

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR: PR Link
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

@techienickb techienickb requested a review from a team as a code owner July 6, 2023 19:13
@ghost
Copy link

ghost commented Jul 6, 2023

Thank you for creating a Pull Request @techienickb.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@gavinbarron
Copy link
Member

thanks for your PR @techienickb

The code looks good at a first pass.
I'll give it a shot with some other work we have in flight that uses this auth scenario.

Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great and works nicely.

@gavinbarron gavinbarron merged commit 1f97215 into microsoftgraph:main Jul 7, 2023
9 checks passed
gavinbarron pushed a commit that referenced this pull request Aug 21, 2023
added custom hosts passthrough
added converter to custom-hosts attribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] v3 401 errors when using a custom api uri scope
2 participants