Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: presence fallback logic #2849

Merged
merged 2 commits into from
Nov 13, 2023
Merged

fix: presence fallback logic #2849

merged 2 commits into from
Nov 13, 2023

Conversation

gavinbarron
Copy link
Member

Closes #2846

PR Type

  • Bugfix

Description of the changes

Ensures that data fetched is used in preference to the fallback details when loading presence. This was a regression introduced in #2786

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Copy link

🚀 New react-contoso sample application deployed here

Copy link

📖 The updated storybook is available here

@gavinbarron gavinbarron enabled auto-merge (squash) November 13, 2023 21:22
Copy link

🚀 New react-contoso sample application deployed here

Copy link

📖 The updated storybook is available here

@gavinbarron gavinbarron merged commit 1ab1970 into main Nov 13, 2023
8 checks passed
@gavinbarron gavinbarron deleted the fix/presence-indicator branch November 13, 2023 21:26
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 81% 100% 0
mgt-components.src.components.mgt-contact 68% 83% 0
mgt-components.src.components.mgt-file 51% 100% 0
mgt-components.src.components.mgt-file-list 56% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 88% 0
mgt-components.src.components.mgt-messages 66% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 79% 65% 0
mgt-components.src.components.mgt-person-card 66% 47% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 89% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 28% 0
mgt-element.dist.es6.components.src.components 73% 79% 0
mgt-element.dist.es6.mock.src.mock 90% 72% 0
mgt-element.dist.es6.providers.src.providers 85% 69% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 66% 69% 0
mgt-element.src 88% 100% 0
mgt-element.src.components 84% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 80% 85% 0
mgt-element.src.utils 71% 90% 0
Summary 65% (12445 / 19049) 64% (415 / 649) 0

Copy link

📖 The updated storybook is available here

Copy link

🚀 New react-contoso sample application deployed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] User presence is not being called on mgt-person
2 participants