-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support multiple chat components sharing a subscription #2913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gavinbarron I have tested this locally by opening two tabs. I sent a message to the same chat from teams. It showed up in one tab and not the other. Is this part of the remaining work?
When you switch an account, shouldn't that be a new session? Hence a new session ID?
@musale the work from AGS to support this change is not yet fully rolled out. We should have that change at the end of this week. Apologies for not indicating that this was dependent on a change on the underlying graph APIs. |
@musale this should be working as we expect now, the change we were waiting on was released into production earlier this week, |
|
Closes #2911
PR Type
Description of the changes
This will allow multiple chat components with the same chatId in the same browser, be it in the same page or over multiple tabs to share a common subscription and independently receive change notifications.
Awaiting a change from AGS to be deployed for complete end to end testing.
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information