fix: only fetch valid X.509 certificates from the certificate store #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perf: remove linq code use to improve code generation
|
I'd like a 2nd set of eyes on the certificate scanning changes cc @baywet, @andrueastman |
baywet
reviewed
Jul 25, 2024
src/Microsoft.Graph.Cli.Core/Authentication/ClientCertificateCredentialFactory.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Graph.Cli.Core/Authentication/ClientCertificateCredentialFactory.cs
Outdated
Show resolved
Hide resolved
baywet
previously approved these changes
Jul 25, 2024
|
I'm adding some tests to improve coverage. |
|
Is it possible to unit test certificates? |
You'd need to generate self-signed certificates as part of the tests setup and add them to the user store. (machine store requires elevation) |
chore: remove redundant certificate date checks
baywet
reviewed
Jul 25, 2024
src/Microsoft.Graph.Cli.Core/Authentication/ClientCertificateCredentialFactory.cs
Show resolved
Hide resolved
…redentialFactory.cs Co-authored-by: Vincent Biret <vibiret@microsoft.com>
|
|
Not sure if I can improve coverage meaningfully anymore... :-/ |
baywet
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perf: remove linq code use to improve code generation