Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in retrieving user photo #10

Closed
rossknudsen opened this issue Oct 5, 2020 · 1 comment · Fixed by #12
Closed

Bug in retrieving user photo #10

rossknudsen opened this issue Oct 5, 2020 · 1 comment · Fixed by #12
Assignees
@jasonjoh
Labels
fixed Fix is complete and will be available to customers as soon as doc updates are published under investigation Issue is being investigated

Comments

@rossknudsen
Copy link

https://github.com/microsoftgraph/msgraph-training-aspnet-core/blob/ffb9ed93a1db10df76e598a1d602443f43945575/demo/GraphTutorial/Startup.cs#L90

I had to adjust this line as follows

if (ex.IsMatch("ErrorItemNotFound") || ex.IsMatch("ConsumerPhotoIsNotSupported"))
@ghost ghost added the needs triage 🔍 New issue, needs triage label Oct 5, 2020
@jasonjoh jasonjoh self-assigned this Oct 12, 2020
@jasonjoh jasonjoh added under investigation Issue is being investigated and removed needs triage 🔍 New issue, needs triage labels Oct 12, 2020
@jasonjoh
Copy link
Member

Thanks @rossknudsen for reporting.

jasonjoh added a commit that referenced this issue Oct 20, 2020
@jasonjoh
Added check for personal account-specific photo error.
1a3dad7 
Personal (consumer) accounts return a specific error because they do not support photos via Graph.

Fixes #10
@jasonjoh jasonjoh mentioned this issue Oct 20, 2020
Merged
@ghost ghost added the in pr An open PR addresses this issue label Oct 20, 2020
@ghost ghost added fixed Fix is complete and will be available to customers as soon as doc updates are published and removed in pr An open PR addresses this issue labels Oct 20, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jasonjoh jasonjoh

Labels
fixed Fix is complete and will be available to customers as soon as doc updates are published under investigation Issue is being investigated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update for Microsoft.Identity.Web GA + bug fixes microsoftgraph/msgraph-sample-aspnet-core
2 participants
@rossknudsen @jasonjoh