Add delegate to PageIterator to allow consumers to configure next page request #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add editorconfig
zengin
previously approved these changes
Dec 2, 2020
There was a problem hiding this comment.
LGTM.
@MIchaelMainer, I think PageIterator needs to go to Core library so that Beta library can also benefit from this.
I see an issue related to PageIterator in the core repo (microsoftgraph/msgraph-sdk-dotnet-core#54), do we have an existing task for the migration itself?
baywet
requested changes
Dec 2, 2020
baywet
previously approved these changes
Dec 2, 2020
MIchaelMainer
approved these changes
Dec 2, 2020
|
@zengin Added microsoftgraph/msgraph-sdk-dotnet-core#179 to track moving this into core. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #852
Changes proposed in this pull request
IBaseRequest) before it is invoked.