Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated v1.0 models and request builders using Typewriter #995

Merged
merged 3 commits into from
May 12, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 11, 2021

This pull request was automatically created by the GitHub Action, create pull request.

The commit hash is 109e071.

Important Check for unexpected deletions or changes in this PR.

  • Check that the changes match the changes in the captured commit for v1.0_metadata.xml
Microsoft Reviewers: Open in CodeFlow

baywet
baywet previously approved these changes May 11, 2021
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the education root change from entity to complex type as I mentioned on the Java review

@MIchaelMainer MIchaelMainer merged commit ffecbd4 into dev May 12, 2021
@MIchaelMainer MIchaelMainer deleted the v1.0/pipelinebuild/49356 branch May 12, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants