Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit logging of GraphServiceException #885

Closed
MaHa6543 opened this issue Jun 1, 2023 · 2 comments · Fixed by #898 or #926
Closed

Remove explicit logging of GraphServiceException #885

MaHa6543 opened this issue Jun 1, 2023 · 2 comments · Fixed by #898 or #926
Labels
enhancement New feature or request
Projects
Graph SDK - Triage

Comments

@MaHa6543
Copy link
Contributor

MaHa6543 commented Jun 1, 2023

CoreHttpProvider.processResponse catches GraphServiceExceptions and writes the exception explicitly with logger.error.

This is not needed because the exception is also thrown afterwards (and can be handled individually by the caller).

The explicit logging should be removed so that the GraphServiceException is no longer written to log in each case.

image
@ghost ghost added the ToTriage label Jun 1, 2023
@ghost ghost added this to Issues to triage in Graph SDK - Triage Jun 1, 2023
@andrueastman andrueastman added enhancement New feature or request and removed ToTriage labels Jun 2, 2023
@baywet
Copy link
Member

baywet commented Jun 7, 2023

Thanks for the suggestion. Would you be willing to submit a pull request to address this?

MaHa6543 added a commit to MaHa6543/msgraph-sdk-java-core that referenced this issue Jun 7, 2023
@MaHa6543
Explicit log to error removed (as described in microsoftgraph#885)
453fa4f
@MaHa6543 MaHa6543 mentioned this issue Jun 7, 2023
Merged
@MaHa6543
Copy link
Contributor Author

MaHa6543 commented Jun 7, 2023

Thanks for the quick response. I submitted pull request #898

ramsessanchez added a commit that referenced this issue Jun 20, 2023
@ramsessanchez
Merge pull request #898 from MaHa6543/dev
145f064 
Explicit log to error removed (described in issue #885)
@ramsessanchez ramsessanchez linked a pull request Jun 20, 2023 that will close this issue
Community contribution/log error fix #926
Merged
Graph SDK - Triage automation moved this from Issues to triage to Closed Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
Graph SDK - Triage
  
Closed
Milestone
No milestone
3 participants
@andrueastman @baywet @MaHa6543