Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/editor-config #581

Merged
merged 2 commits into from
Dec 1, 2020
Merged

feature/editor-config #581

merged 2 commits into from
Dec 1, 2020

Conversation

baywet
Copy link
Member

@baywet baywet commented Dec 1, 2020

I've been fighting with tabs and spaces for a while now. This comes from the very good suggestion from @pschaeflein

@baywet baywet self-assigned this Dec 1, 2020
@baywet baywet added this to the 2.4.2 milestone Dec 1, 2020
@zengin
Copy link
Contributor

zengin commented Dec 1, 2020

This is useful for handcrafting files in this repo, but I don't think it will fix the auto-generated files.

I think we should start from MSGraph-SDK-Code-Generator repo. Most code we generate there is using spaces (width: 4). I would suggest setting the standard to that for minimal effect on file history.

@baywet
Copy link
Member Author

baywet commented Dec 1, 2020

@zengin thanks for the suggestion. I've added a configuration for tt files as well on the generator. microsoftgraph/MSGraph-SDK-Code-Generator#336
It only seems to work when opening VS in folder mode and for the part that's not specific (only the CSharp that's not part of the template text gets indented). But it should come handy as we switch to dotnet-core and vs code for the generator.

@baywet baywet merged commit 24dbfdc into dev Dec 1, 2020
@baywet baywet deleted the feature/editor-config branch December 1, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants