1. Changed property value param to accept array of strings in select,

expand, orderby methods. 2. Fixed compilation error by adding required libraries in config.
microsoftgraph · May 23, 2018 · 5f44a2b · 5f44a2b
1 parent a12bd44
commit 5f44a2b
Show file tree

Hide file tree

Showing 12 changed files with 413 additions and 383 deletions.
diff --git a/lib/graph-js-sdk-web.js b/lib/graph-js-sdk-web.js
diff --git a/lib/spec/core/responseHandling.d.ts b/lib/spec/core/responseHandling.d.ts
@@ -0,0 +1 @@
+export {};
diff --git a/lib/spec/core/urlGeneration.d.ts b/lib/spec/core/urlGeneration.d.ts
@@ -0,0 +1 @@
+export {};
diff --git a/lib/spec/core/urlGeneration.js.map b/lib/spec/core/urlGeneration.js.map
diff --git a/lib/spec/core/urlParsing.d.ts b/lib/spec/core/urlParsing.d.ts
@@ -0,0 +1 @@
+export {};
diff --git a/lib/spec/core/urlParsing.js.map b/lib/spec/core/urlParsing.js.map
diff --git a/lib/src/GraphRequest.d.ts b/lib/src/GraphRequest.d.ts
@@ -16,9 +16,9 @@ export declare class GraphRequest {
     private urlJoin(urlSegments);
     buildFullUrl(): string;
     version(v: string): GraphRequest;
-    select(properties: string | [string]): GraphRequest;
-    expand(properties: string | [string]): GraphRequest;
-    orderby(properties: string | [string]): GraphRequest;
+    select(properties: string | string[]): GraphRequest;
+    expand(properties: string | string[]): GraphRequest;
+    orderby(properties: string | string[]): GraphRequest;
     filter(filterStr: string): GraphRequest;
     top(n: number): GraphRequest;
     skip(n: number): GraphRequest;

diff --git a/lib/src/GraphRequest.js.map b/lib/src/GraphRequest.js.map
diff --git a/lib/src/ResponseHandler.js.map b/lib/src/ResponseHandler.js.map
diff --git a/lib/src/index.js.map b/lib/src/index.js.map
diff --git a/src/GraphRequest.ts b/src/GraphRequest.ts
@@ -127,17 +127,17 @@ export class GraphRequest {
      *     and .select("displayName", "birthday")
      * 
      */
-    select(properties:string|[string]):GraphRequest {
+    select(properties:string|string[]):GraphRequest {
         this.addCsvQueryParamater("$select", properties, arguments);
         return this;
     }
 
-    expand(properties:string|[string]):GraphRequest {
+    expand(properties:string|string[]):GraphRequest {
         this.addCsvQueryParamater("$expand", properties, arguments);
         return this;
     }
 
-    orderby(properties:string|[string]):GraphRequest {
+    orderby(properties:string|string[]):GraphRequest {
         this.addCsvQueryParamater("$orderby", properties, arguments);
         return this;
     }
@@ -174,7 +174,7 @@ export class GraphRequest {
     }
 
     // helper for $select, $expand and $orderby (must be comma separated)
-    private addCsvQueryParamater(propertyName:string, propertyValue:string|[string], additionalProperties:IArguments) {
+    private addCsvQueryParamater(propertyName:string, propertyValue:string|string[], additionalProperties:IArguments) {
         // if there are already $propertyName value there, append a ","
         this.urlComponents.oDataQueryParams[propertyName] = this.urlComponents.oDataQueryParams[propertyName] ? this.urlComponents.oDataQueryParams[propertyName] + "," : "";
 

diff --git a/tsconfig.json b/tsconfig.json
@@ -7,6 +7,7 @@
     "removeComments": true,
     "sourceMap": true,
     "target": "es5",
+    "lib": ["es6", "dom"],
     "declaration": true,
     "outDir": "lib/"
   },