Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported node versions(12 & 14) from the pipeline #1405

Merged

Conversation

koros
Copy link
Contributor

@koros koros commented Aug 17, 2023

A similar PR may already be submitted! Please search among the Pull request before creating one.

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request.

NOTE: PR's will be accepted only in case of appropriate information is provided below

Summary

Remove versions of node that are no longer supported, 12 & 14, from the pipeline build configuration

Motivation

Explain the motivation for making this change. What existing problem does the pull request solve?

Test plan

Demonstrate the code is solid. Example: The exact commands you ran and their output.

Closing issues

Fixes #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes

@MIchaelMainer
Copy link
Contributor

Replaces #1403

baywet
baywet previously approved these changes Aug 21, 2023
@MIchaelMainer
Copy link
Contributor

In cases where we remove a workflow that is required by policy, we need to do one of the following actions:

  • Create a PR that removes the deprecated workflow from the policy specification before we remove the workflow. In this PR, we required that the matrix build for node versions 12 and 14 pass before are allowed to merge this PR into the dev branch.
  • Elevate to admin to force the merge.

@MIchaelMainer MIchaelMainer merged commit 5cbc14d into dev Aug 22, 2023
9 checks passed
@MIchaelMainer MIchaelMainer deleted the feature/remove-deprecated-node-versions-from-pipeline branch August 22, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants