-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unsupported node versions(12 & 14) from the pipeline #1405
Remove unsupported node versions(12 & 14) from the pipeline #1405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be updated too https://github.com/microsoftgraph/msgraph-sdk-javascript/blob/dev/.github/workflows/ci_validation.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes
Replaces #1403 |
In cases where we remove a workflow that is required by policy, we need to do one of the following actions:
|
A similar PR may already be submitted! Please search among the Pull request before creating one.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request.
NOTE: PR's will be accepted only in case of appropriate information is provided below
Summary
Remove versions of node that are no longer supported, 12 & 14, from the pipeline build configuration
Motivation
Explain the motivation for making this change. What existing problem does the pull request solve?
Test plan
Demonstrate the code is solid. Example: The exact commands you ran and their output.
Closing issues
Fixes #
Types of changes
Checklist