-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md with download as binary example #96
Conversation
README.md
Outdated
````js | ||
client | ||
.api(`/me/drive/root/children/${fileName}/content`) | ||
.responseType("blob") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should specify what the other magic strings options are for the responseType argument. Even better, we should have a ResponseType.ts enum with proper comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, its good to have a ResponseType.ts with comments..! Will update this pull request.
Updated with changes:
Comments added for enum in ResponseType.ts will not be available in the corresponding .d.ts and .js files. As this compiler option modification comes in this change. We will recompile this .ts file to have comments in its .d.ts and .js files once we merge above change. Yes,
|
cc: @MIchaelMainer @darrelmiller