-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support overwriting existing headers & response exception updates #55
Conversation
@MIchaelMainer @SilasKenneth just confirming that the versioning is ok for breaking changes in a preview release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also start an upgrade document to capture what changes are breaking. We will link to it in release notes and blog post announcements.
The version change is fine since it is still RC for a major version change.. |
Should we update the existing v1 & beta RC's to use versions of core |
Can we leverage this guide and add a section at the top for upgrading between the current RC versions? |
Yes, the sooner the better.
Yes, good idea. |
Once the change to upgrade guide is added we should be good here. |
@MIchaelMainer Please see the related PR's on v1 and beta |
Changes:
array_merge
to allow customers to overwrite our default header values. Appending values will be at the discretion of the developerSome breaking changes here:
GraphResponseException
takes in aStreamInterface
as opposed to an arraygetRawResponseBody()
return type changes fromarray
toStreamInterface
Closes #53
Closes #54