Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing description, synopsis and examples for handwritten authentication cmdlets #2333

Merged
merged 11 commits into from
Oct 3, 2023
Merged

Adds missing description, synopsis and examples for handwritten authentication cmdlets #2333

merged 11 commits into from
Oct 3, 2023

Conversation

timayabi2020
Copy link
Collaborator

Fixes #2332

@timayabi2020 timayabi2020 requested a review from a team as a code owner October 2, 2023 11:36
@timayabi2020 timayabi2020 linked an issue Oct 2, 2023 that may be closed by this pull request
Review synopsis, description, and examples for handwritten cmdlets #2332
Closed
calebkiage
calebkiage previously approved these changes Oct 2, 2023
View reviewed changes
peombwa
peombwa requested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@peombwa peombwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor updates the descriptions.

src/Authentication/descriptions/Set-MgRequestContext.md Outdated Show resolved Hide resolved
src/Authentication/descriptions/Get-MgGraphOption.md Outdated Show resolved Hide resolved
src/Authentication/descriptions/Set-MgGraphOption.md Outdated Show resolved Hide resolved
src/Authentication/descriptions/Set-MgEnvironment.md Outdated Show resolved Hide resolved
src/Authentication/synopsis/Get-MgGraphOption.md Outdated Show resolved Hide resolved
src/Authentication/synopsis/Set-MgRequestContext.md Outdated Show resolved Hide resolved
src/Authentication/synopsis/Set-MgGraphOption.md Outdated Show resolved Hide resolved
timayabi2020 and others added 8 commits October 2, 2023 20:56
@timayabi2020 @peombwa
Update src/Authentication/synopsis/Set-MgGraphOption.md
623009e 
Co-authored-by: Peter Ombwa <peombwa@microsoft.com>
@timayabi2020 @peombwa
Update src/Authentication/descriptions/Set-MgEnvironment.md
6b36c3f 
Co-authored-by: Peter Ombwa <peombwa@microsoft.com>
@timayabi2020 @peombwa
Update src/Authentication/descriptions/Get-MgGraphOption.md
fb13d4d 
Co-authored-by: Peter Ombwa <peombwa@microsoft.com>
@timayabi2020 @peombwa
Update src/Authentication/synopsis/Get-MgGraphOption.md
ea0cf1b 
Co-authored-by: Peter Ombwa <peombwa@microsoft.com>
@timayabi2020 @peombwa
Update src/Authentication/synopsis/Set-MgRequestContext.md
9e8cb6a 
Co-authored-by: Peter Ombwa <peombwa@microsoft.com>
@timayabi2020 @peombwa
Update src/Authentication/descriptions/Set-MgGraphOption.md
ad2c90d 
Co-authored-by: Peter Ombwa <peombwa@microsoft.com>
@timayabi2020 @peombwa
Update src/Authentication/descriptions/Set-MgRequestContext.md
e777d41 
Co-authored-by: Peter Ombwa <peombwa@microsoft.com>
@timayabi2020
Updated docs according to PR review suggestions
f6a8e19
@timayabi2020 timayabi2020 merged commit 991c433 into dev Oct 3, 2023
2 of 3 checks passed
@timayabi2020 timayabi2020 deleted the 2332-review-synopsis-description-and-examples-for-handwritten-cmdlets branch October 3, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peombwa peombwa peombwa approved these changes

@calebkiage calebkiage calebkiage left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review synopsis, description, and examples for handwritten cmdlets
3 participants
@timayabi2020 @calebkiage @peombwa