Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Invalid JWT token using a personal account #2388

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Fixes Invalid JWT token using a personal account #2388

merged 3 commits into from
Oct 30, 2023

Conversation

peombwa
Copy link
Member

@peombwa peombwa commented Oct 25, 2023

Fixes #2386 due to https://stackoverflow.com/questions/66210139/why-my-valid-ms-access-token-cant-be-parsed-with-jwt-ms.

Changes proposed in this pull request

  • Updates code to ensure we only decode JWT access tokens. Non-JWT tokens won't be decoded as they don't conform to https://tools.ietf.org/html/rfc7519.
  • Adds unit tests to validate access token decoding.

@peombwa peombwa requested a review from a team as a code owner October 25, 2023 23:07
@peombwa peombwa merged commit 0fceedb into dev Oct 30, 2023
3 checks passed
@peombwa peombwa deleted the bugfixes/PersonalAccountAuth branch October 30, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timayabi2020 timayabi2020 timayabi2020 approved these changes

@MIchaelMainer MIchaelMainer MIchaelMainer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid JWT access token
3 participants
@peombwa @MIchaelMainer @timayabi2020