Updated Module Classification #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the current module structure by purging invalid cmdlets and grouping related cmdlets into one module. The layout is based on the previously shared Excel file.
Change proposed in this PR reduces the current module footprint from 99 to 31 modules. The reduction is mostly attributed to the
remove-path-by-operationdirective, which removes invalid/redundant navigation properties/ OpenAPI paths from being generated into cmdlets. e.g.One can only list a drive’s activities, and all calls to
/drives/{drive-id}/activities/*will always result in a 400 – resource not found for the segment. Since this path is invalid, remove-path-by-operation directive in Files module will remove all/drives/{drive-id}/*/activity/*paths and only retain a single GET path to list a drive’s activities. See docs for more information.Given the large size of PR, it is easier to review the following files in the branch to see what changes have been made:
/src/{ModuleName}/ { ModuleName }/readme.md(directives applied to the module) e.g. Groups readme.md./src/{ModuleName}/ { ModuleName }/Microsoft.Graph.{ ModuleName }.psd1(names of generated cmdlets) e.g. Microsoft.Graph.Groups.psd1Closes #336 #345 #344