Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle case where network is down or the endpoint is unreachable #712

Merged
merged 4 commits into from Jun 24, 2021
Merged

Handle case where network is down or the endpoint is unreachable #712

merged 4 commits into from Jun 24, 2021

Conversation

georgend
Copy link
Contributor

Handle case where network is down or the endpoint is unreachable making ResponseMessage null.
Earlier behavior would suppress network errors.
Current Behavior
Suppresses network errors throws ArgumentNullException in HttpMessageFormatter

image

Proposed Behavior
When network errors occur, let them propagate to Cmdlet Error handling.
image

Handle case where network is down or the endpoint is unreachable maki…
19cd5d1 
…ng ResponseMessage null.

Earlier behavior would suppress network errors.
@georgend georgend requested a review from peombwa June 22, 2021 12:48
@georgend georgend self-assigned this Jun 22, 2021
@georgend georgend linked an issue Jun 22, 2021 that may be closed by this pull request
custom module Finally should not dereference ResponseMessage as it suppresses network exception #700
Closed
@georgend georgend added this to the 1.7.0 milestone Jun 22, 2021
@georgend georgend added this to In progress in Graph SDK - Powershell via automation Jun 22, 2021
@georgend georgend added the Bug label Jun 22, 2021
@georgend georgend marked this pull request as ready for review June 22, 2021 12:49
@georgend georgend requested a review from ddyett as a code owner June 22, 2021 12:49
@georgend georgend requested a review from shemogumbe June 23, 2021 12:47
@peombwa peombwa mentioned this pull request Jun 23, 2021
Closed
Graph SDK - Powershell automation moved this from In progress to Reviewer approved Jun 23, 2021
@georgend georgend merged commit 327587f into dev Jun 24, 2021
Graph SDK - Powershell automation moved this from Reviewer approved to Done Jun 24, 2021
@georgend georgend deleted the bugfixes/suppressedNetworkExceptions branch June 24, 2021 16:40
@peombwa peombwa mentioned this pull request Jul 7, 2021
Merged
@peombwa peombwa mentioned this pull request Sep 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peombwa peombwa peombwa approved these changes

@ddyett ddyett Awaiting requested review from ddyett

@shemogumbe shemogumbe Awaiting requested review from shemogumbe

Assignees

@georgend georgend

Labels
Bug
Projects
No open projects
Graph SDK - Powershell
  
Done
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

custom module Finally should not dereference ResponseMessage as it suppresses network exception
2 participants
@georgend @peombwa