Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make -Body optional for POST and PATCH Requests. #955

Merged
merged 20 commits into from
Dec 9, 2021
Merged

Make -Body optional for POST and PATCH Requests. #955

merged 20 commits into from
Dec 9, 2021

Conversation

georgend
Copy link
Contributor

Remove validation rule for POST and PATCH requests to have a Body through the -Body parameter.
Fix up failing and skipped IGR tests.

@finsharp
Remove -Skip on invoke commands.
477e31d 
Remove unused infra.
Remove validation rule for Body with Post/Path Requests.
@finsharp
Remove validation rule.
bf17ccd
@georgend georgend self-assigned this Nov 29, 2021
@georgend georgend linked an issue Nov 29, 2021 that may be closed by this pull request
Invoke-MgGraphRequest should not require -Body to be present to make a POST request #887
Closed
peombwa
peombwa reviewed Nov 29, 2021
View reviewed changes
tools/Utilities/utils.ps1 Outdated Show resolved Hide resolved
tools/Utilities/utils.ps1 Outdated Show resolved Hide resolved
@georgend georgend added this to the 11/21 milestone Nov 30, 2021
@georgend georgend requested a review from peombwa December 2, 2021 20:18
@peombwa peombwa modified the milestones: 11/21, 12/21 Dec 7, 2021
peombwa
peombwa requested changes Dec 8, 2021
View reviewed changes
Copy link
Member

@peombwa peombwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we have a failing test:

CommandNotFoundException: The term 'Disconnect-AzAccount' is not recognized as a name of a cmdlet, function, script file, or executable program

@georgend georgend merged commit 734a299 into dev Dec 9, 2021
@peombwa peombwa mentioned this pull request Dec 16, 2021
Merged
@peombwa peombwa deleted the bugfixes/POSTBodyOptional branch January 7, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peombwa peombwa peombwa approved these changes

@ddyett ddyett Awaiting requested review from ddyett

@shemogumbe shemogumbe Awaiting requested review from shemogumbe

Assignees

@georgend georgend

Labels
None yet
Projects
None yet
Milestone
12/21
Development

Successfully merging this pull request may close these issues.

Invoke-MgGraphRequest should not require -Body to be present to make a POST request
3 participants
@georgend @peombwa @finsharp