Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FY2020Q1 quarterly refresh #15

Merged
merged 29 commits into from Sep 13, 2019
Merged

FY2020Q1 quarterly refresh #15

merged 29 commits into from Sep 13, 2019

Conversation

andrewconnell
Copy link
Contributor

  • Updated all packages versions
  • Updated exercise instructions
  • Updated slide decks

.gitignore Show resolved Hide resolved
@jasonjoh
Copy link
Member

Thanks for the update @andrewconnell. I wanted to explain the deal with appsettings.json. I understand that the file didn't have any actual secrets in it. However, having it tracked in the repo sets you up to inadvertently commit your app ID/secret, since you have to modify it after cloning/forking to run the sample. I've done it multiple times :).

Because of this, the approach we've taken with these repos is that we first make sure that the app ID/secret is in a separate file somewhere, not inline in code. Then we make sure to .gitignore that file. Finally, we add an example of the file (with a .example extension) with placeholders. So for example, in this repo you'd have appsettings.json.example. In the README you can instruct the user to rename the file to appsettings.json, add their app ID/secret, and they're good to go. Does that make sense?

I think it would be helpful to add the .example files to your demos and update the corresponding READMEs.

@andrewconnell
Copy link
Contributor Author

@jasonjoh OK... so you're saying to just add the appsettings.json.example to each demo with the placeholders, and include in the demo's README.md file instructions on (1) rename, (2) edit settings. That's all... correct?

@jasonjoh
Copy link
Member

Yep, that's the pattern we've been using. Alternatively you'd need to tell them to create from scratch, which might be fine too. Up to you.

@andrewconnell
Copy link
Contributor Author

@jasonjoh Just added the example files to the demos with updated README instructions. I think this is what you were requesting. If not, can you let me know and I'll fix?

@jasonjoh jasonjoh merged commit 5972112 into microsoftgraph:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants