Extract expectations #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like you're using npm. Let's keep the repo consistent and only use yarn for package management. |
microsoftly
requested changes
Sep 2, 2017
src/ExpectedMessage.ts
Outdated
| @@ -160,7 +143,7 @@ export class ExpectedMessage { | |||
| delete expectedResponse.agent; | |||
|
|
|||
| try { | |||
| expectWithDeepMatch(clone).to.deep.match(expectedResponse); | |||
| expect(clone).toDeepMatch(expectedResponse); | |||
There was a problem hiding this comment.
To help make this cleaner, lets change this to be toDeeplyInclude and replace the expectedResponseCollectionsAsIMessage loop wtih
expect(expectedResponseCollectionAsIMessage).toDeeplyInclude(expectedResponse)There was a problem hiding this comment.
I made some of the changes. How would you handle the processing done to every message in the collection if we remove the forEach block ?
bilby91
force-pushed
the
extract-expectations
branch
from
fbe75f9
to
9e58819
Compare
bilby91
force-pushed
the
extract-expectations
branch
from
9e58819
to
9459ac3
Compare
microsoftly
approved these changes
Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@microsoftly I extracted the expectation logic. I couldn't integrate with
jestbecause it seems that the run and the expectation are not decoupled. I think this should be a good beginning for integrating new expectation frameworks.