separating Ruby and ROR rubocop configs #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nidalaa
requested changes
Dec 20, 2019
README.md
Outdated
| @@ -59,6 +60,7 @@ In that case check detailed instructions for each linter: | |||
|
|
|||
| - [css](./css#troubleshooting) | |||
| - [ruby](./ruby#troubleshooting) | |||
| - [Ruby on Rails](./ror) | |||
There was a problem hiding this comment.
It should be ./ror#troubleshooting
| - "bin/*" | ||
| - "db/**/*" | ||
| - "config/**/*" | ||
| - "Guardfile" |
There was a problem hiding this comment.
Let's leave Guardfile and Rakefile here please 🙏
|
|
||
| # add the files here you want to be ignored by stylelint | ||
| files: | ||
| ignore: |
There was a problem hiding this comment.
please make sure that ignore contains the same files as exclude here https://github.com/microverseinc/linters-config/pull/29/files#diff-bb818e2d66f2dd3502ac21100eb9d755R2
|
hello @nidalaa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ror/folder and copied.rubocop.ymlconfig file i worked on few days ago which was a little less restrictive(or more friendly)ruby/folder intoror/folderruby/.rubocop.ymlfile configs specific to RAILS projectsror/.rubocop.ymlfile if there should be anything specific to ruby alone (it was OK)