Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc dev - TextField #47

Merged
merged 9 commits into from
Aug 23, 2023
Merged

Doc dev - TextField #47

merged 9 commits into from
Aug 23, 2023

Conversation

HY0118
Copy link
Collaborator

@HY0118 HY0118 commented Aug 22, 2023

TextField Docs Page 제작
MoaTextField에서 지원하는 Props를 조작 및 코드 복사할 수 있도록 UI 개발

image

@HY0118 HY0118 added the documentation Improvements or additions to documentation label Aug 22, 2023
@HY0118 HY0118 requested review from kh1012 and bce0404 August 22, 2023 11:38
@HY0118 HY0118 self-assigned this Aug 22, 2023
@HY0118 HY0118 changed the title Doc dev textfield Doc dev - TextField Aug 22, 2023
Copy link
Collaborator

@bce0404 bce0404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

승인!

Copy link
Collaborator

@kh1012 kh1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 부탁드립니다 :)

}));

const StyledBox = styled(Box)(({ theme }) => ({
borderLeft : isSelected ? `2px solid #30a9f0` : '1px solid #c5d0d1',
borderRadius: isSelected ? "0.2rem" : "0rem",
borderLeft : isSelected ? `2.5px solid #4587f7` : '1px solid #edeef0',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moaui의 Color export가 필요해보입니다!

@@ -1,9 +1,249 @@
import React from "react";
import Button from "@midasit-dev/moaui/dist/Button";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엌 이 친구는 갑자기 /dist/가 붙은 이유가 있을까요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이것은 다른 PR과 같은 내용이므로 pass~!

@@ -8,9 +7,6 @@ export default function Docs() {
<div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

div로 감싼 영역을 지운다면 더 깔끔해질 것 같아요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

부모요소로 감싸주긴 해야해서 Header 컴포넌트를 감싸고 있는 div만 삭제하였습니다~!

@HY0118 HY0118 merged commit 7b39677 into doc_dev Aug 23, 2023
@HY0118 HY0118 deleted the dov_dev_textfield branch August 28, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants