Switch Demo에 MoaSwtich Component 조작 UI 개발 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch component 옆에 보이는 text에 대한 prop 이름을 name에서 label로 변경 (쓰이는 목적을 기준으로 props이름이 name은 적당하지 않다고 판단.)
kh1012
approved these changes
Aug 28, 2023
src/lib/Switch/Demo.tsx
Outdated
| import Typography from "@mui/material/Typography"; | ||
| import MUISwitch from "@mui/material/Switch"; | ||
|
|
||
| export function SwitchCompo(props: any) { |
There was a problem hiding this comment.
props를 사용하지 않는다면 비워도 괜찮을 것 같습니다
There was a problem hiding this comment.
넵 불필요한 코드라 제거하였습니다.
bce0404
reviewed
Aug 28, 2023
음 이부분은 제가 처음에 switch 컴포넌트를 개발한 사항이 아니라서 의도는 잘 모르겠습니다. 이슈로 남겨주세용 |
bce0404
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch Demo에 MoaSwtich Component 조작 UI 개발