Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : TabGroup과 Tab 사용 시 onChange event가 적절하게 동작하지 않음. #65

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

bce0404
Copy link
Collaborator

@bce0404 bce0404 commented Sep 18, 2023

Tab을 TabGroup과 사용하는 경우 다음과 같은 이슈가 발견되었습니다.

  • TabGroup의 onChange 이벤트가 제대로 호출되지 않음.
  • TabGroup의 value가 TabGroup 밖에서 변경되는 경우 TabGroup에 반영되지 않음. (현재 선택된 값이 보여지는 것과 일치하지 않을 수 있음)

위 문제를 수정하여 onChange 이벤트가 제대로 발생되고,
Value가 TabGroup 밖에서 변경되는 경우 TabGroup에서도 반영되도록 변경하였습니다 :)

@bce0404 bce0404 changed the base branch from main to dev September 18, 2023 07:36
@bce0404 bce0404 self-assigned this Sep 18, 2023
@bce0404 bce0404 added the bug Something isn't working label Sep 18, 2023
Copy link
Collaborator

@kh1012 kh1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 완료 했습니다!

@bce0404 bce0404 merged commit 976c2d3 into dev Sep 19, 2023
@bce0404 bce0404 deleted the feature/TabGroup-not-synching branch September 19, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants