offices page cta/address, revised offices meta order, social links #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since the container has half a gutter width padding on either side to make the grid rows/cols line up correctly, the 16px gutter on xs wasn't enough.
|
@imcbride is there anything you need from me on this? |
|
Not at this time, but I'll let you know if something comes up. I'm working through this today and have a block ready which displays the address information on all group pages. I just need to step through your markup and make sure I apply all of the changes to my templates. I understand this has taken a while, but last week was essentially a wash between the ITIL training, catching up on support, and WordPress 5.0. I'll also be in a security workshop all day tomorrow. |
|
I'm not 100% certain that I've applied all of the changes here correctly, but I'm merging this as its mostly working in the live site and I'll deploy it so that it can be tested against real content. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@imcbride Any issues with changes here?