Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to soft unset an AsciiDoc attribute value in the config #72

Closed
mojavelinux opened this issue Dec 11, 2017 · 2 comments
Closed
Assignees
Milestone

Comments

@mojavelinux
Copy link
Contributor

mojavelinux commented Dec 11, 2017

This integration sets several implicit attribute values, such as imagesdir. It should be possible to unset these attributes, either globally or per page, while still allowing the attribute to be set in the document. We'll call this a "soft" unset.

@mojavelinux mojavelinux added this to the v1.0.0 milestone Dec 11, 2017
@mojavelinux mojavelinux self-assigned this Dec 11, 2017
@mojavelinux
Copy link
Contributor Author

There are two proposals on the table.

The first proposal is to combine the negated attribute (!name) with the soft set flag, @.

'!name' => '@'

The problem with this proposal is that it's being considered for core as a way to unset implicit attributes in Asciidoctor itself. If we hijack it, then we may lose that ability.

The other is to use a subtraction syntax:

'-name' => ''

The latter is implemented in the Jekyll plugin. We could support the second syntax until the fate of the first syntax is resolved.

@mojavelinux
Copy link
Contributor Author

As part of this change, custom attributes should be resolved after all implicit attributes (imagesdir, imagesoutdir, relfilesuffix, etc) are assigned by this extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant