Rename Contribute to Community in main nav #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdreyno
reviewed
Feb 14, 2017
locales/jp.yml
Outdated
| docs: Docs | ||
| logo: Middleman | ||
| search_placeholder: ドキュメント検索 |
There was a problem hiding this comment.
Is this search_placeholder removal on purpose?
There was a problem hiding this comment.
It’s not used anywhere.
There was a problem hiding this comment.
Maybe it should be?
There was a problem hiding this comment.
It appears that it should be used here, but isn’t: https://github.com/middleman/middleman-guides/blob/master/source/partials/_docsearch.erb#L3
There was a problem hiding this comment.
Looks like it was originally added long ago in c339021#diff-98e97cfa6efa32a2e18600bef3e4bc27R7, but wasn’t used when the search functionality changed.
There was a problem hiding this comment.
I put up a fixup commit which updates the template to use this translation: 61f6c8c
tysongach
force-pushed
the
tg-community
branch
from
ea720f0
to
61f6c8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.