Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we ~> 3.1.0 or maybe ~> 3.3.0? #69

Closed
komor72 opened this issue Dec 5, 2014 · 1 comment
Closed

Should we ~> 3.1.0 or maybe ~> 3.3.0? #69

komor72 opened this issue Dec 5, 2014 · 1 comment

Comments

@komor72
Copy link
Contributor

komor72 commented Dec 5, 2014

The Readme.md for this plugin still instructs to put gem "middleman-livereload", "~> 3.1.0" in the Gemfile. Shouldn’t we already depend on 3.3.x current version?
@tdreyno
Copy link
Member

tdreyno commented Dec 5, 2014

You're right, it should be 3.3

@komor72 komor72 mentioned this issue Dec 7, 2014
Merged
komor72 added a commit to komor72/middleman-templates-default that referenced this issue Dec 7, 2014
@komor72
Updated gem declaration to 3.3.x.
3f5e865 
As per discussion middleman/middleman-livereload#69 (comment)
@komor72 komor72 mentioned this issue Dec 7, 2014
Closed
@komor72 komor72 closed this as completed Dec 7, 2014
komor72 added a commit to komor72/middleman that referenced this issue Sep 3, 2015
@komor72
Update middleman-livereload version to more current
0d4d82a 
As discussed middleman/middleman-livereload#69 but I forgot to apply the fix to source code inside MM. @tdreyno, should it be `~> 3.3.0` or `~> 3.4.0`? I looked into 3.4 changes and they seem to be MM v4 related?
@komor72 komor72 mentioned this issue Sep 3, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tdreyno @komor72