Fix htmlcompressor Content-Length computation #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r than on characters number (which is not the same, e.g. with accented characters)
|
Thanks so much for the patch. Did this already go into the upstream repo? |
tdreyno
added a commit
that referenced
this pull request
Jul 7, 2013
…-contentlength Fix htmlcompressor Content-Length computation
|
I created a PR, but it's not merged yet : paolochiodi/htmlcompressor#9 Thanks for merging :-) |
michaelbaudino
added a commit
to alpinelab/website
that referenced
this pull request
Jul 7, 2013
|
Hi, I just fixed this in paolochiodi/htmlcompressor#7 |
|
Okay, this is out with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes how htmlcompressor computes Content-Length.
It should be based on the number of bytes, rather than on the number of characters (which differs, e.g. with accented characters).
It should fix this issue : http://forum.middlemanapp.com/t/middleman-minify-html-content-length-header-error/697
Check out this IRB session:
2.0.0-p247 :001 > 'é'.length
=> 1
2.0.0-p247 :002 > 'é'.bytesize
=> 2