Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gemfile #13

Closed
wants to merge 1 commit into from
Closed

Conversation

johnsorrentino
Copy link

Unpin middleman and middleman-autoprefixer to resolve middleman/middleman#2463

Unpin `middleman` and `middleman-autoprefixer` to resolve middleman/middleman#2463
@jankoegel
Copy link

jankoegel commented Nov 27, 2022

Can we get this merged? It was very confusing to start a new Middleman project and run into the error from middleman#2463 as well as middleman/middleman#2480 - middleman seemed broken from the start. Took me a while to find the fix here.
Would be much appreciated, thanks!

@gbirchmeier
Copy link

Just puzzled my way through this. As a noob to this project, it was a pain in the butt. Dunno why this isn't merged yet.

@johnsorrentino
Copy link
Author

Hey @tdreyno, thoughts on this change?

@tdreyno
Copy link
Member

tdreyno commented Jan 20, 2023

@johnsorrentino I think we still need to keep the ranges. The middleman one shouldn't be causing issues. It seems the above link is about middleman-autoprefixer needing to be 3.x instead of 2.x?

These two comments seem to have it right.

middleman/middleman#2463 (comment)
middleman/middleman#2463 (comment)

So:

ruby '>= 2.7', '< 3.0'

gem 'middleman', '~> 4.4'
gem 'middleman-autoprefixer', '~> 3.0'

@gbirchmeier
Copy link

gbirchmeier commented Jan 21, 2023

@tdreyno - as long as you put out a release of middleman that can do init then build without erroring out, you can choose whichever solution you want.

See middleman/middleman#2613 for what I ran into 2 weeks ago as a noob to this project. IMO, the latest release is just broken. You can't even create and build a demo project.

@tdreyno
Copy link
Member

tdreyno commented Jan 23, 2023

@gbirchmeier you are not welcome here if you cannot be civil. This is a 15 year old project which hasn't had a major release in 7 years. I don't appreciate the entitled attitude. Either you can help the community contribute fixes, like John is doing, or you can leave.

@gbirchmeier
Copy link

I apologize for my tone, which as I reread it does seem more out-of-line than I intended.

I also run an open-source project, and people have been entitled jerks to me, so I fully apologize and am embarrassed to be on the other side of that.

When you are able, I look forward to a minor release that corrects the init then build error.

jagthedrummer added a commit to jagthedrummer/middleman-templates-default that referenced this pull request Jan 28, 2023
Making the updates to the `Gemfile` that will make it so that `middleman init` doesn't generate a broken project out of the box.

middleman#13 (comment)
@jagthedrummer jagthedrummer mentioned this pull request Jan 28, 2023
@jagthedrummer
Copy link

Here's a PR that gets the starter project working for me. (Everything seems to work fine with ruby 3.1.2, so I left out the bits about pinning ruby.)

#15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

css 404 error after build
5 participants