asset_host + jQuery producing invalid javascript?

[joshukraine]

I have a couple of MM4 projects which use Gulp in conjunction with the new external_pipeline. Both projects require jQuery. I've noticed that if I activate the asset_host feature in config.rb as outlined in the Middleman docs, the javascript bundle generated by middleman build is invalid. (The error from eslint, for example, is Parsing error: Unexpected token * A similar error is displayed in the browser console in production.)

The following two repos illustrate this issue. The first uses Webpack to bundle the js, the second uses Browserify. Both use Gulp and both require jQuery.

1. Webpack example: https://github.com/joshukraine/middleman-gulp-starter
2. Browserify example: https://github.com/joshukraine/mm4-example

I've discussed this issue at some length with Craig Dennis (author of middleman-gulp-starter), and it would appear that the asset host URL is not being properly quoted in the bundled javascript.

If I remove the asset_host setting, the javascript bundle is valid. Also, if I don't require jQuery, the javascript bundle is valid. But if I combine the two, I get syntax errors. Any thoughts?

Thank you.

[joshukraine]

Video walkthrough illustrating steps to reproduce the issue: https://youtu.be/xRlU38q-QxU

Updated example repo with full instructions in README: https://github.com/joshukraine/asset-host-jquery-issue

[joshukraine]

It would appear this is related to #1780.

[joshukraine]

UPDATE: Found a possible workaround. Adding the :rewrite_ignore option to config.rb tells Middleman not to insert asset host URLs in specified file types.

# config.rb

configure :build do
  activate :asset_host,
    :host => '//YOURDOMAIN.cloudfront.net',
    :rewrite_ignore => ["*.js"]

  # More configs...
end

Reference:

• middleman/middleman-core/lib/middleman-core/extensions/asset_host.rb
• middleman/middleman-core/lib/middleman-core/util.rb

[tdreyno]

Thanks. There's definitely a regex issue I need to look into

[tdreyno]

I can't reproduce with MM github master. Can you take a look?

[tdreyno]

Wait, nm, forgot to remove the ignore line

[tdreyno]

Okay, give master a shot now

[joshukraine]

@tdreyno Yep, working for me. Thanks for the fix!