Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract gem slowdown middleman by a lot #2261

Closed
brodock opened this issue Mar 19, 2019 · 6 comments
Closed

Contract gem slowdown middleman by a lot #2261

brodock opened this issue Mar 19, 2019 · 6 comments
Labels

Comments

@brodock
Copy link

brodock commented Mar 19, 2019

Expected behavior and actual behavior

In a big middleman installation, the Contract gem is a difference of waiting a couple of seconds or some minutes before middleman server can start taking requests.

Steps to reproduce the problem (from a clean middleman installation)

Try out with http://gitlab.com/gitlab-com/www-gitlab-com/

middleman server

and

export NO_CONTRACTS=yes && middleman server

Additional information

  • Ruby version: 2.5.3
  • Middleman version: 4.3.3
  • OS version: Mac OS Mojave
@tdreyno
Copy link
Member

tdreyno commented Mar 19, 2019

This is known and why the NO_CONTRACTS exists.

In v5, they will be defaulting to off. This is the ticket where we're tracking getting gitlab on v5: #2228

@smcgivern
Copy link

@brodock also note that we set NO_CONTRACTS=true in our .gitlab-ci.yml 😃

https://gitlab.com/gitlab-com/www-gitlab-com/blob/master/.gitlab-ci.yml#L9

@brodock
Copy link
Author

brodock commented Mar 20, 2019

@smcgivern yeah, I figured out that eventually, but still, when running on local machine that is not automatically set.

@stale
Copy link

stale bot commented Jul 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 17, 2021
@stale stale bot closed this as completed Jul 24, 2021
@shaunakv1
Copy link

@tdreyno
is there a way to set NO_CONTRACTS=true equivalent from the config.rb for middleman 4?

@tdreyno
Copy link
Member

tdreyno commented Apr 8, 2022

No, because Ruby has already started up by the time config.rb is read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants