Extract compass

[tdreyno]

Really happy with this PR. Started by extracting Compass support into a middleman-compass extension, which required rewriting a bunch of features in Ruby (which we mostly already had) instead of relying on Compass. Lead to nice cleanups all around and heavy usage of the Inline Asset rewriting middleware.

Once this is merged, I'll actually move middleman-compass into its own repo. The question is, do we reference it in the over-gem middleman or require users to add it to their Gemfile?

[Arcovion]

If it's moved into it's own gem, why not change compass_config &block to activate :compass &block?
This way you avoid the extra hook and configure it all in one place.

Since it's for v4 I think it's okay to break backwards-compatibility, it's easy to migrate and it'd look more elegant as all of the middleman extensions use that syntax.

[tdreyno]

@Arcovion Seems like a good idea, if we decide to break backwards compat.

[tdreyno]

Ping @bhollis @karlfreeman

[bhollis]

I'll have some time to take a look next week - I'm excited about it!

[karlfreeman]

Same as @bhollis. Less is more 👍.

[karlfreeman]

This looks really great!

I'm assuming the logic behind compass_config.environment = :development is to ensure we don't get any production defaults that we're not explicitly setting ourselves?

I would be a fan of requiring users to add it to their Gemfile. Compass is a framework, you wouldn't include Foundation by default, so why Compass. However, not including it by default would need an explanation during the upgrade notes. So can see both sides of it.

👍

[tdreyno]

@karlfreeman Correct. That's the way it currently works in stable as well.

Same question for Sprockets too. I'd like to encourage folks to not use either as much, so maybe we pull it out and require a Gemfile change... and see if people get angry. Easily reversible.

[coveralls]

Changes Unknown when pulling 47bcafd on deprecate_compass into * on master*.

[bhollis]

If you register this with the auto_activate: :before_configuration option, you won't need the AUTOLOAD_COMPASS stuff.

[tdreyno]

Sounds good.

[bhollis]

This is awesome. Good work extracting it! My main comment is the one around using the auto_activate stuff, and also that after this is committed you might want to split it into its own repo.

[renatocarvalho]

\o/